Changeset 73244 in webkit
- Timestamp:
- Dec 2, 2010 11:25:10 PM (13 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r73241 r73244 1 2010-12-02 Gregg Tavares <gman@google.com> 2 3 Reviewed by David Levin. 4 5 Need to initialize destination variables before calling GL 6 https://bugs.webkit.org/show_bug.cgi?id=50048 7 8 No new tests because no change in functionality. 9 10 * html/canvas/WebGLFramebuffer.cpp: 11 (WebCore::WebGLFramebuffer::initializeRenderbuffers): 12 * html/canvas/WebGLProgram.cpp: 13 (WebCore::WebGLProgram::cacheActiveAttribLocations): 14 * html/canvas/WebGLRenderingContext.cpp: 15 (WebCore::WebGLRenderingContext::getAttachedShaders): 16 (WebCore::WebGLRenderingContext::getBufferParameter): 17 (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): 18 (WebCore::WebGLRenderingContext::getBooleanParameter): 19 (WebCore::WebGLRenderingContext::getFloatParameter): 20 (WebCore::WebGLRenderingContext::getLongParameter): 21 (WebCore::WebGLRenderingContext::getUnsignedLongParameter): 22 * platform/graphics/chromium/LayerChromium.cpp: 23 (WebCore::loadShader): 24 (WebCore::LayerChromium::createShaderProgram): 25 * platform/graphics/chromium/LayerRendererChromium.cpp: 26 (WebCore::LayerRendererChromium::initializeSharedObjects): 27 * platform/graphics/gpu/DrawingBuffer.cpp: 28 (WebCore::DrawingBuffer::reset): 29 * platform/graphics/gpu/Shader.cpp: 30 (WebCore::Shader::loadProgram): 31 1 32 2010-12-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> 2 33 -
trunk/WebCore/html/canvas/WebGLFramebuffer.cpp
r72433 r73244 234 234 float colorClearValue[] = {0, 0, 0, 0}, depthClearValue = 0; 235 235 int stencilClearValue = 0; 236 unsigned char colorMask[] = { 1, 1, 1, 1}, depthMask = 1;236 unsigned char colorMask[] = {0, 0, 0, 0}, depthMask = 0; 237 237 unsigned int stencilMask = 0xffffffff; 238 238 bool isScissorEnabled = false; -
trunk/WebCore/html/canvas/WebGLProgram.cpp
r69804 r73244 68 68 return false; 69 69 GraphicsContext3D* context3d = context()->graphicsContext3D(); 70 int linkStatus ;70 int linkStatus = 0; 71 71 context3d->getProgramiv(object(), GraphicsContext3D::LINK_STATUS, &linkStatus); 72 72 if (!linkStatus) -
trunk/WebCore/html/canvas/WebGLRenderingContext.cpp
r72610 r73244 1376 1376 if (numShaders) { 1377 1377 OwnArrayPtr<unsigned int> shaders(new unsigned int[numShaders]); 1378 int count ;1378 int count = 0; 1379 1379 m_context->getAttachedShaders(objectOrZero(program), numShaders, &count, shaders.get()); 1380 1380 if (count != numShaders) … … 1416 1416 1417 1417 WebGLStateRestorer(this, false); 1418 int value ;1418 int value = 0; 1419 1419 m_context->getBufferParameteriv(target, pname, &value); 1420 1420 if (pname == GraphicsContext3D::BUFFER_SIZE) … … 1460 1460 if (pname != GraphicsContext3D::FRAMEBUFFER_ATTACHMENT_OBJECT_NAME) { 1461 1461 WebGLStateRestorer(this, false); 1462 int value ;1462 int value = 0; 1463 1463 m_context->getFramebufferAttachmentParameteriv(target, attachment, pname, &value); 1464 1464 if (pname == GraphicsContext3D::FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE) … … 3353 3353 WebGLGetInfo WebGLRenderingContext::getBooleanParameter(unsigned long pname) 3354 3354 { 3355 unsigned char value ;3355 unsigned char value = 0; 3356 3356 m_context->getBooleanv(pname, &value); 3357 3357 return WebGLGetInfo(static_cast<bool>(value)); … … 3374 3374 WebGLGetInfo WebGLRenderingContext::getFloatParameter(unsigned long pname) 3375 3375 { 3376 float value ;3376 float value = 0; 3377 3377 m_context->getFloatv(pname, &value); 3378 3378 return WebGLGetInfo(static_cast<float>(value)); … … 3386 3386 WebGLGetInfo WebGLRenderingContext::getLongParameter(unsigned long pname) 3387 3387 { 3388 int value ;3388 int value = 0; 3389 3389 m_context->getIntegerv(pname, &value); 3390 3390 return WebGLGetInfo(static_cast<long>(value)); … … 3393 3393 WebGLGetInfo WebGLRenderingContext::getUnsignedLongParameter(unsigned long pname) 3394 3394 { 3395 int value ;3395 int value = 0; 3396 3396 m_context->getIntegerv(pname, &value); 3397 3397 unsigned int uValue = static_cast<unsigned int>(value); -
trunk/WebCore/platform/graphics/chromium/LayerChromium.cpp
r72021 r73244 60 60 GLC(context, context->shaderSource(shader, sourceString)); 61 61 GLC(context, context->compileShader(shader)); 62 int compiled ;62 int compiled = 0; 63 63 GLC(context, context->getShaderiv(shader, GraphicsContext3D::COMPILE_STATUS, &compiled)); 64 64 if (!compiled) { … … 229 229 230 230 GLC(context, context->linkProgram(programObject)); 231 int linked ;231 int linked = 0; 232 232 GLC(context, context->getProgramiv(programObject, GraphicsContext3D::LINK_STATUS, &linked)); 233 233 if (!linked) { -
trunk/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
r72770 r73244 844 844 845 845 // Get the max texture size supported by the system. 846 m_maxTextureSize = 0; 846 847 GLC(m_context, m_context->getIntegerv(GraphicsContext3D::MAX_TEXTURE_SIZE, &m_maxTextureSize)); 847 848 -
trunk/WebCore/platform/graphics/gpu/DrawingBuffer.cpp
r72431 r73244 114 114 // resize multisample FBO 115 115 if (multisample()) { 116 int maxSampleCount ;116 int maxSampleCount = 0; 117 117 118 118 m_context->getIntegerv(Extensions3D::MAX_SAMPLES, &maxSampleCount); -
trunk/WebCore/platform/graphics/gpu/Shader.cpp
r68802 r73244 92 92 context->attachShader(program, fragmentShader); 93 93 context->linkProgram(program); 94 int linkStatus ;94 int linkStatus = 0; 95 95 context->getProgramiv(program, GraphicsContext3D::LINK_STATUS, &linkStatus); 96 96 if (!linkStatus)
Note: See TracChangeset
for help on using the changeset viewer.