Changeset 73312 in webkit


Ignore:
Timestamp:
Dec 3, 2010 3:25:55 PM (13 years ago)
Author:
weinig@apple.com
Message:

Enable <a ping> for Mac/Windows/WebKit2 builds
<rdar://problem/8504473>
​https://bugs.webkit.org/show_bug.cgi?id=50488

Reviewed by Maciej Stachowiak.

WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.

WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHyperlinkAuditingEnabled):
(WKPreferencesGetHyperlinkAuditingEnabled):

  • UIProcess/API/C/WKPreferences.h:

Add "HyperlinkAuditing" preference and enabled it by default.

WebKitTools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST): Test that the default value of
WKPreferencesGetHyperlinkAuditingEnabled is true.

Location:
trunk
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/mac/ChangeLog

    r73287 r73312  
     12010-12-03  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Enable <a ping> for Mac/Windows/WebKit2 builds
     6        <rdar://problem/8504473>
     7        https://bugs.webkit.org/show_bug.cgi?id=50488
     8
     9        * WebView/WebPreferences.mm:
     10        (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
     11
    1122010-12-03  Jia Pu  <jpu@apple.com>
    213

  • trunk/WebKit/mac/WebView/WebPreferences.mm

    r72141 r73312  
    369369        [NSNumber numberWithBool:NO],   WebKitFullScreenEnabledPreferenceKey,
    370370        [NSNumber numberWithBool:NO],   WebKitMemoryInfoEnabledPreferenceKey,
    371         [NSNumber numberWithBool:NO],   WebKitHyperlinkAuditingEnabledPreferenceKey,
     371        [NSNumber numberWithBool:YES],  WebKitHyperlinkAuditingEnabledPreferenceKey,
    372372        [NSNumber numberWithBool:NO],   WebKitUsePreHTML5ParserQuirksKey,
    373373        [NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,

  • trunk/WebKit/win/ChangeLog

    r73305 r73312  
     12010-12-03  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Enable <a ping> for Mac/Windows/WebKit2 builds
     6        <rdar://problem/8504473>
     7        https://bugs.webkit.org/show_bug.cgi?id=50488
     8
     9        * WebPreferences.cpp:
     10        (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
     11
    1122010-12-03  Brian Weinstein  <bweinstein@apple.com>
    213

  • trunk/WebKit/win/WebPreferences.cpp

    r72141 r73312  
    265265
    266266    CFDictionaryAddValue(defaults, CFSTR(WebKitMemoryInfoEnabledPreferenceKey), kCFBooleanFalse);
    267     CFDictionaryAddValue(defaults, CFSTR(WebKitHyperlinkAuditingEnabledPreferenceKey), kCFBooleanFalse);
     267    CFDictionaryAddValue(defaults, CFSTR(WebKitHyperlinkAuditingEnabledPreferenceKey), kCFBooleanTrue);
    268268
    269269    defaultSettings = defaults;

  • trunk/WebKit2/ChangeLog

    r73310 r73312  
     12010-12-03  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Enable <a ping> for Mac/Windows/WebKit2 builds
     6        <rdar://problem/8504473>
     7        https://bugs.webkit.org/show_bug.cgi?id=50488
     8
     9        * Shared/WebPreferencesStore.h:
     10        * UIProcess/API/C/WKPreferences.cpp:
     11        (WKPreferencesSetHyperlinkAuditingEnabled):
     12        (WKPreferencesGetHyperlinkAuditingEnabled):
     13        * UIProcess/API/C/WKPreferences.h:
     14        Add "HyperlinkAuditing" preference and enabled it by default.
     15
    1162010-12-03  Brady Eidson  <beidson@apple.com>
    217

  • trunk/WebKit2/Shared/WebPreferencesStore.h

    r73297 r73312  
    5050    macro(TextAreasAreResizable, textAreasAreResizable, Bool, bool, true) \
    5151    macro(JavaScriptCanOpenWindowsAutomatically, javaScriptCanOpenWindowsAutomatically, Bool, bool, true) \
     52    macro(HyperlinkAuditingEnabled, hyperlinkAuditingEnabled, Bool, bool, true) \
    5253    macro(NeedsSiteSpecificQuirks, needsSiteSpecificQuirks, Bool, bool, false) \
    5354    macro(AcceleratedCompositingEnabled, acceleratedCompositingEnabled, Bool, bool, true) \

  • trunk/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r73215 r73312  
    141141}
    142142
     143void WKPreferencesSetHyperlinkAuditingEnabled(WKPreferencesRef preferencesRef, bool hyperlinkAuditingEnabled)
     144{
     145    toImpl(preferencesRef)->setHyperlinkAuditingEnabled(hyperlinkAuditingEnabled);
     146}
     147
     148bool WKPreferencesGetHyperlinkAuditingEnabled(WKPreferencesRef preferencesRef)
     149{
     150    return toImpl(preferencesRef)->hyperlinkAuditingEnabled();
     151}
     152
    143153void WKPreferencesSetStandardFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
    144154{

  • trunk/WebKit2/UIProcess/API/C/WKPreferences.h

    r73215 r73312  
    7878WK_EXPORT bool WKPreferencesGetJavaScriptCanOpenWindowsAutomatically(WKPreferencesRef preferences);
    7979
     80// Defaults to true.
     81WK_EXPORT void WKPreferencesSetHyperlinkAuditingEnabled(WKPreferencesRef preferences, bool hyperlinkAuditingEnabled);
     82WK_EXPORT bool WKPreferencesGetHyperlinkAuditingEnabled(WKPreferencesRef preferences);
     83
    8084WK_EXPORT void WKPreferencesSetStandardFontFamily(WKPreferencesRef preferencesRef, WKStringRef family);
    8185WK_EXPORT WKStringRef WKPreferencesCopyStandardFontFamily(WKPreferencesRef preferencesRef);

  • trunk/WebKitTools/ChangeLog

    r73302 r73312  
     12010-12-03  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Enable <a ping> for Mac/Windows/WebKit2 builds
     6        <rdar://problem/8504473>
     7        https://bugs.webkit.org/show_bug.cgi?id=50488
     8
     9        * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
     10        (TestWebKitAPI::TEST): Test that the default value of
     11        WKPreferencesGetHyperlinkAuditingEnabled is true.
     12
    1132010-12-03  Chris Guillory  <chris.guillory@google.com>
    214

  • trunk/WebKitTools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp

    r73187 r73312  
    7272    TEST_ASSERT(WKPreferencesGetJavaEnabled(preference) == true);
    7373    TEST_ASSERT(WKPreferencesGetJavaScriptCanOpenWindowsAutomatically(preference) == true);
     74    TEST_ASSERT(WKPreferencesGetHyperlinkAuditingEnabled(preference) == true);
    7475    WKRetainPtr<WKStringRef> standardFontFamily(AdoptWK, WKPreferencesCopyStandardFontFamily(preference));
    7576    TEST_ASSERT(WKStringIsEqualToUTF8CString(standardFontFamily.get(), expectedStandardFontFamily));
Note: See TracChangeset for help on using the changeset viewer.