Changeset 73319 in webkit

Timestamp:

Dec 3, 2010 4:11:49 PM (13 years ago)

Author:

Dimitri Glazkov

Message:

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

• fast/forms/text-input-event-expected.txt: Added.
• fast/forms/text-input-event.html: Added.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

Now that events escape the shadow DOM boundary, the input event is fired twice
for each input, once triggered by editing, once triggered by value change.

Test: fast/forms/text-input-event.html

• dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields

don't fire an extra input event.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/text-input-event-expected.txt (added)
• LayoutTests/fast/forms/text-input-event.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/InputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION(r71934): input event fires twice when editing text inside a text input.
+        https://bugs.webkit.org/show_bug.cgi?id=50477
+
+        * fast/forms/text-input-event-expected.txt: Added.
+        * fast/forms/text-input-event.html: Added.
+
 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION(r71934): input event fires twice when editing text inside a text input.
+        https://bugs.webkit.org/show_bug.cgi?id=50477
+
+        Now that events escape the shadow DOM boundary, the input event is fired twice
+        for each input, once triggered by editing, once triggered by value change.
+
+        Test: fast/forms/text-input-event.html
+
+        * dom/InputElement.cpp:
+        (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields
+            don't fire an extra input event.
+
 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/dom/InputElement.cpp

@@ -139 +139 @@
     element->setFormControlValueMatchesRenderer(true);
 
-    element->dispatchEvent(Event::create(eventNames().inputEvent, true, false));
+    // Input event is fired by the Node::defaultEventHandler for editable controls.
+    if (!inputElement->isTextField())
+        element->dispatchEvent(Event::create(eventNames().inputEvent, true, false));
     notifyFormStateChanged(element);
 }