Changeset 73398 in webkit


Ignore:
Timestamp:
Dec 6, 2010 1:57:35 PM (13 years ago)
Author:
aestes@apple.com
Message:

2010-12-06 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
​https://bugs.webkit.org/show_bug.cgi?id=50434

Test: fast/html/marquee-scrollamount.html

  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::timerFired): Allow increment to be 0.

2010-12-06 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
​https://bugs.webkit.org/show_bug.cgi?id=50434

  • fast/html/marquee-scrollamount.html: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r73388 r73398  
     12010-12-06  Andy Estes  <aestes@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Marquee elements do not stop animating when scrollAmount is set to 0.
     6        https://bugs.webkit.org/show_bug.cgi?id=50434
     7
     8        * fast/html/marquee-scrollamount.html: Added.
     9        * platform/mac/fast/html/marquee-scrollamount-expected.checksum: Added.
     10        * platform/mac/fast/html/marquee-scrollamount-expected.png: Added.
     11        * platform/mac/fast/html/marquee-scrollamount-expected.txt: Added.
     12
    1132010-12-06  Chris Fleizach  <cfleizach@apple.com>
    214

  • trunk/WebCore/ChangeLog

    r73397 r73398  
     12010-12-06  Andy Estes  <aestes@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Marquee elements do not stop animating when scrollAmount is set to 0.
     6        https://bugs.webkit.org/show_bug.cgi?id=50434
     7
     8        Test: fast/html/marquee-scrollamount.html
     9
     10        * rendering/RenderMarquee.cpp:
     11        (WebCore::RenderMarquee::timerFired): Allow increment to be 0.
     12
    1132010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/WebCore/rendering/RenderMarquee.cpp

    r73385 r73398  
    294294        bool positive = range > 0;
    295295        int clientSize = (isHorizontal() ? m_layer->renderBox()->clientWidth() : m_layer->renderBox()->clientHeight());
    296         int increment = max(1, abs(m_layer->renderer()->style()->marqueeIncrement().calcValue(clientSize)));
     296        int increment = abs(m_layer->renderer()->style()->marqueeIncrement().calcValue(clientSize));
    297297        int currentPos = (isHorizontal() ? m_layer->scrollXOffset() : m_layer->scrollYOffset());
    298298        newPos =  currentPos + (addIncrement ? increment : -increment);
Note: See TracChangeset for help on using the changeset viewer.