Changeset 73459 in webkit


Ignore:
Timestamp:
Dec 7, 2010 2:01:58 PM (13 years ago)
Author:
mjs@apple.com
Message:

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

  • fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
  • fast/html/hidden-attr-expected.txt: Added.
  • fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r73454 r73459  
     12010-12-07  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Implement HTML5 hidden attribute
     6        https://bugs.webkit.org/show_bug.cgi?id=40511
     7       
     8        * fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
     9        * fast/html/hidden-attr-expected.txt: Added.
     10        * fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.
     11
    1122010-12-07  Philippe Normand  <pnormand@igalia.com>
    213
  • trunk/LayoutTests/fast/forms/caret-rtl.html

    r42585 r73459  
    1919    Click in the div, the caret should be on the right edge of the div.
    2020</p>
    21 <div CONTENTEDITABLE id="test" style="direction: rtl; width:200px; font-size:2000%"; outline: solid thin; overflow: hidden></div>
     21<div CONTENTEDITABLE id="test" style="direction: rtl; width:200px; font-size:2000%; outline: solid thin"></div>
    2222</body>
    2323<script> runTest(); </script>
  • trunk/WebCore/ChangeLog

    r73458 r73459  
     12010-12-07  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Implement HTML5 hidden attribute
     6        https://bugs.webkit.org/show_bug.cgi?id=40511
     7
     8        Test: fast/html/hidden-attr.html
     9
     10        * html/HTMLElement.cpp:
     11        (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute.
     12        (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
     13
    1142010-12-07  Kenneth Russell  <kbr@google.com>
    215
  • trunk/WebCore/html/HTMLElement.cpp

    r72259 r73459  
    117117bool HTMLElement::mapToEntry(const QualifiedName& attrName, MappedAttributeEntry& result) const
    118118{
    119     if (attrName == alignAttr ||
    120         attrName == contenteditableAttr) {
     119    if (attrName == alignAttr
     120        || attrName == contenteditableAttr
     121        || attrName == hiddenAttr) {
    121122        result = eUniversal;
    122123        return false;
     
    143144    } else if (attr->name() == contenteditableAttr) {
    144145        setContentEditable(attr);
     146    } else if (attr->name() == hiddenAttr) {
     147        addCSSProperty(attr, CSSPropertyDisplay, CSSValueNone);
    145148    } else if (attr->name() == tabindexAttr) {
    146149        indexstring = getAttribute(tabindexAttr);
Note: See TracChangeset for help on using the changeset viewer.