Changeset 73622 in webkit

Timestamp:

Dec 9, 2010 10:26:54 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-09 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Check the return value of ImageBuffer::create()
to avoid crash when ImageBuffer::create() fails.
​https://bugs.webkit.org/show_bug.cgi?id=50631

No new test because it relies on the platform implementation
of ImageBuffer. It is hard to make ImageBuffer::create() fail
in most ports.

• platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GeneratedImage.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-09  Yong Li  <yoli@rim.com>
+
+        Reviewed by Darin Adler.
+
+        Check the return value of ImageBuffer::create()
+        to avoid crash when ImageBuffer::create() fails.
+        https://bugs.webkit.org/show_bug.cgi?id=50631
+
+        No new test because it relies on the platform implementation
+        of ImageBuffer. It is hard to make ImageBuffer::create() fail
+        in most ports.
+
+        * platform/graphics/GeneratedImage.cpp:
+        (WebCore::GeneratedImage::drawPattern):
+
 2010-12-09  Maciej Stachowiak  <mjs@apple.com>
 

trunk/WebCore/platform/graphics/GeneratedImage.cpp

@@ -58 +58 @@
     // Create a BitmapImage and call drawPattern on it.
     OwnPtr<ImageBuffer> imageBuffer = ImageBuffer::create(adjustedSize);
-    ASSERT(imageBuffer.get());
+    if (!imageBuffer)
+        return;
 
     // Fill with the gradient.