Changeset 73669 in webkit


Ignore:
Timestamp:
Dec 9, 2010 5:58:47 PM (13 years ago)
Author:
zmo@google.com
Message:

2010-12-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
​https://bugs.webkit.org/show_bug.cgi?id=36512

Test: fast/canvas/webgl/instanceof-test.html

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled): (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled): (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled): (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
  • html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
  • html/canvas/WebGLBuffer.idl: Ditto.
  • html/canvas/WebGLFramebuffer.idl: Ditto.
  • html/canvas/WebGLProgram.idl: Ditto.
  • html/canvas/WebGLRenderbuffer.idl: Ditto.
  • html/canvas/WebGLShader.idl: Ditto.
  • html/canvas/WebGLTexture.idl: Ditto.
  • html/canvas/WebGLUniformLocation.idl: Ditto.
  • page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.

2010-12-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
​https://bugs.webkit.org/show_bug.cgi?id=36512

  • fast/canvas/webgl/instanceof-test-expected.txt: Added.
  • fast/canvas/webgl/instanceof-test.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto. (constructorNamesForWindow):
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/js/script-tests/global-constructors.js: Ditto.
Location:
trunk
Files:
2 added
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r73663 r73669  
     12010-12-09  Zhenyao Mo  <zmo@google.com>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        Expose constructor functions for instanceof checks of WebGL objects
     6        https://bugs.webkit.org/show_bug.cgi?id=36512
     7
     8        * fast/canvas/webgl/instanceof-test-expected.txt: Added.
     9        * fast/canvas/webgl/instanceof-test.html: Added.
     10        * fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
     11        * fast/dom/Window/window-properties.html: Ditto.
     12        * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
     13        (constructorNamesForWindow):
     14        * fast/dom/script-tests/prototype-inheritance.js: Ditto.
     15        * fast/js/script-tests/global-constructors.js: Ditto.
     16
    1172010-12-09  James Robinson  <jamesr@chromium.org>
    218

  • trunk/LayoutTests/fast/dom/Window/script-tests/window-property-descriptors.js

    r72718 r73669  
    2121    // Ignore these properties because they do not exist in all implementations. They will be tested separately
    2222    "WebGLRenderingContext" : 1,
     23    "WebGLActiveInfo" : 1,
     24    "WebGLBuffer" : 1,
     25    "WebGLFramebuffer" : 1,
     26    "WebGLProgram" : 1,
     27    "WebGLRenderbuffer" : 1,
     28    "WebGLShader" : 1,
     29    "WebGLTexture" : 1,
     30    "WebGLUniformLocation" : 1,
    2331    "ArrayBuffer" : 1,
    2432    "DataView" : 1,

  • trunk/LayoutTests/fast/dom/Window/window-properties.html

    r72718 r73669  
    6363    // Ignore these properties because they do not exist in all implementations. They will be tested separately
    6464    "window.WebGLRenderingContext" : 1,
     65    "window.WebGLActiveInfo" : 1,
     66    "window.WebGLBuffer" : 1,
     67    "window.WebGLFramebuffer" : 1,
     68    "window.WebGLProgram" : 1,
     69    "window.WebGLRenderbuffer" : 1,
     70    "window.WebGLShader" : 1,
     71    "window.WebGLTexture" : 1,
     72    "window.WebGLUniformLocation" : 1,
    6573    "window.ArrayBuffer" : 1,
    6674    "window.DataView" : 1,

  • trunk/LayoutTests/fast/dom/script-tests/prototype-inheritance-2.js

    r72718 r73669  
    6060        var type = classNameForObject(value);
    6161        // Ignore these properties because they do not exist in all implementations. They will be tested separately
    62         if (type == "WebGLRenderingContextConstructor" ||
     62        if (type == "WebGLRenderingContextConstructor" ||
     63            type == "WebGLActiveInfoConstructor" ||
     64            type == "WebGLBufferConstructor" ||
     65            type == "WebGLFramebufferConstructor" ||
     66            type == "WebGLProgramConstructor" ||
     67            type == "WebGLRenderbufferConstructor" ||
     68            type == "WebGLShaderConstructor" ||
     69            type == "WebGLTextureConstructor" ||
     70            type == "WebGLUniformLocationConstructor" ||
    6371            type == "ArrayBufferConstructor" ||
    6472            type == "DataViewConstructor" ||

  • trunk/LayoutTests/fast/dom/script-tests/prototype-inheritance.js

    r72718 r73669  
    1616    "webkitNotifications",
    1717    "webkitPerformance",
    18     "WebGLRenderingContext",
     18    "WebGLRenderingContext", "WebGLActiveInfo", "WebGLBuffer", "WebGLFramebuffer", "WebGLProgram", "WebGLRenderbuffer", "WebGLShader", "WebGLTexture", "WebGLUniformLocation",
    1919    "ArrayBuffer",
    2020    "DataView", "Int8Array", "Uint8Array", "Int16Array", "Uint16Array", "Int32Array", "Uint32Array", "Float32Array",

  • trunk/LayoutTests/fast/js/script-tests/global-constructors.js

    r72718 r73669  
    1919    // Ignore these properties because they do not exist in all implementations. They will be tested separately
    2020    if (name == "WebGLRenderingContext" ||
     21        name == "WebGLActiveInfo" ||
     22        name == "WebGLBuffer" ||
     23        name == "WebGLFramebuffer" ||
     24        name == "WebGLProgram" ||
     25        name == "WebGLRenderbuffer" ||
     26        name == "WebGLShader" ||
     27        name == "WebGLTexture" ||
     28        name == "WebGLUniformLocation" ||
    2129        name == "ArrayBuffer" ||
    2230        name == "DataView" ||

  • trunk/WebCore/ChangeLog

    r73666 r73669  
     12010-12-09  Zhenyao Mo  <zmo@google.com>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        Expose constructor functions for instanceof checks of WebGL objects
     6        https://bugs.webkit.org/show_bug.cgi?id=36512
     7
     8        Test: fast/canvas/webgl/instanceof-test.html
     9
     10        * bindings/generic/RuntimeEnabledFeatures.h:
     11        (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled):
     12        (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled):
     13        (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled):
     14        (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled):
     15        (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled):
     16        (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled):
     17        (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled):
     18        (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
     19        * html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
     20        * html/canvas/WebGLBuffer.idl: Ditto.
     21        * html/canvas/WebGLFramebuffer.idl: Ditto.
     22        * html/canvas/WebGLProgram.idl: Ditto.
     23        * html/canvas/WebGLRenderbuffer.idl: Ditto.
     24        * html/canvas/WebGLShader.idl: Ditto.
     25        * html/canvas/WebGLTexture.idl: Ditto.
     26        * html/canvas/WebGLUniformLocation.idl: Ditto.
     27        * page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.
     28
    1292010-12-09  Timothy Hatcher  <timothy@apple.com>
    230

  • trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r72718 r73669  
    113113    static bool webGLUnsignedIntArrayEnabled() { return isWebGLEnabled; }
    114114    static bool webGLFloatArrayEnabled() { return isWebGLEnabled; }
     115    static bool webGLActiveInfoEnabled() { return isWebGLEnabled; }
     116    static bool webGLBufferEnabled() { return isWebGLEnabled; }
     117    static bool webGLFramebufferEnabled() { return isWebGLEnabled; }
     118    static bool webGLProgramEnabled() { return isWebGLEnabled; }
     119    static bool webGLRenderbufferEnabled() { return isWebGLEnabled; }
     120    static bool webGLShaderEnabled() { return isWebGLEnabled; }
     121    static bool webGLTextureEnabled() { return isWebGLEnabled; }
     122    static bool webGLUniformLocationEnabled() { return isWebGLEnabled; }
    115123#endif
    116124

  • trunk/WebCore/html/canvas/WebGLActiveInfo.idl

    r52534 r73669  
    2727
    2828    interface [
    29         Conditional=3D_CANVAS,
    30         OmitConstructor
     29        Conditional=3D_CANVAS
    3130    ] WebGLActiveInfo {
    3231        readonly attribute int size;

  • trunk/WebCore/html/canvas/WebGLBuffer.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLBuffer {
     27    interface [Conditional=3D_CANVAS] WebGLBuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLFramebuffer.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLFramebuffer {
     27    interface [Conditional=3D_CANVAS] WebGLFramebuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLProgram.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLProgram {
     27    interface [Conditional=3D_CANVAS] WebGLProgram {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLRenderbuffer.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLRenderbuffer {
     27    interface [Conditional=3D_CANVAS] WebGLRenderbuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLShader.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLShader {
     27    interface [Conditional=3D_CANVAS] WebGLShader {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLTexture.idl

    r52534 r73669  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLTexture {
     27    interface [Conditional=3D_CANVAS] WebGLTexture {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLUniformLocation.idl

    r52534 r73669  
    2626
    2727module html {
    28     interface [Conditional=3D_CANVAS, OmitConstructor] WebGLUniformLocation {
     28    interface [Conditional=3D_CANVAS] WebGLUniformLocation {
    2929    };
    3030}

  • trunk/WebCore/page/DOMWindow.idl

    r73283 r73669  
    486486        attribute CanvasRenderingContext2DConstructor CanvasRenderingContext2D;
    487487        attribute ImageDataConstructor ImageData;
     488        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLActiveInfoConstructor WebGLActiveInfo;
     489        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLBufferConstructor WebGLBuffer;
     490        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLFramebufferConstructor WebGLFramebuffer;
     491        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLProgramConstructor WebGLProgram;
     492        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLRenderbufferConstructor WebGLRenderbuffer;
    488493        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLRenderingContextConstructor WebGLRenderingContext;
     494        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLShaderConstructor WebGLShader;
     495        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLTextureConstructor WebGLTexture;
     496        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLUniformLocationConstructor WebGLUniformLocation;
    489497        attribute TextMetricsConstructor TextMetrics;
    490498
Note: See TracChangeset for help on using the changeset viewer.