Changeset 73732 in webkit

Timestamp:

Dec 10, 2010 8:50:33 AM (13 years ago)

Author:

mario@webkit.org

Message:

2010-12-10 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] AX: implement isEnabled in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50814

Unskip passing accessibility/aria-disabled.html test.

• platform/gtk/Skipped: Unskip test.

2010-12-10 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] AX: implement isEnabled in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50814

Implement AccessibilityUIElement::isEnabled() for GTK.

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (checkElementState): New function to refactor common code. (AccessibilityUIElement::isEnabled): Implement this by checking the current state of the AtkObject. (AccessibilityUIElement::isSelected): Use the new checkElementState function.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] AX: implement isEnabled in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=50814
+
+        Unskip passing accessibility/aria-disabled.html test.
+
+        * platform/gtk/Skipped: Unskip test.
+
 2010-12-10  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -57 +57 @@
 #   Tests failing
 accessibility/aria-combobox.html
-accessibility/aria-disabled.html
 accessibility/ellipsis-text.html
 accessibility/aria-help.html

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] AX: implement isEnabled in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=50814
+
+        Implement AccessibilityUIElement::isEnabled() for GTK.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (checkElementState): New function to refactor common code.
+        (AccessibilityUIElement::isEnabled): Implement this by checking
+        the current state of the AtkObject.
+        (AccessibilityUIElement::isSelected): Use the new
+        checkElementState function.
+
 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

@@ -372 +372 @@
 }
 
+static bool checkElementState(PlatformUIElement element, AtkStateType stateType)
+{
+    if (!ATK_IS_OBJECT(element))
+         return false;
+
+    PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(element)));
+    return atk_state_set_contains_state(stateSet.get(), stateType);
+}
+
 bool AccessibilityUIElement::isEnabled()
 {
-    // FIXME: implement
-    return false;
-}
-
+    return checkElementState(m_element, ATK_STATE_ENABLED);
+}
 
 int AccessibilityUIElement::insertionPointLineNumber()
@@ -399 +406 @@
 bool AccessibilityUIElement::isSelected() const
 {
-    if (!ATK_IS_OBJECT(m_element))
-        return false;
-
-    PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(m_element)));
-    gboolean isSelected = atk_state_set_contains_state(stateSet.get(), ATK_STATE_SELECTED);
-
-    return isSelected;
+    return checkElementState(m_element, ATK_STATE_SELECTED);
 }