Changeset 73804 in webkit


Ignore:
Timestamp:
Dec 10, 2010 2:30:29 PM (13 years ago)
Author:
eric@webkit.org
Message:

2010-12-10 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should report port/platform information when commenting on flaky test bugs
https://bugs.webkit.org/show_bug.cgi?id=50839

Renamed platform.py to platforminfo.py. This broke import platform in executive.py
which was only used by new run webkit tests (and clearly not unit tested).

  • Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
Location:
trunk/WebKitTools
Files:
3 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r73798 r73804  
     12010-12-10  Eric Seidel  <eric@webkit.org>
     2
     3        Unreviewed.
     4
     5        commit-queue should report port/platform information when commenting on flaky test bugs
     6        https://bugs.webkit.org/show_bug.cgi?id=50839
     7
     8        Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
     9        which was only used by new run webkit tests (and clearly not unit tested).
     10
     11        * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
     12        * Scripts/webkitpy/tool/main.py:
     13        * Scripts/webkitpy/tool/mocktool.py:
     14
    1152010-12-10  Eric Seidel  <eric@webkit.org>
    216
  • trunk/WebKitTools/Scripts/webkitpy/common/system/platforminfo.py

    r73798 r73804  
    3131
    3232# We use this instead of calls to platform directly so allow mocking.
    33 # It's unclear if we should allow instantiation of multiple of these
    34 # objects (like we do Ports for rebaseline commands, etc.),
    35 # or if it should just be a mocking layer for python's platform.py
    36 class Platform(object):
     33class PlatformInfo(object):
    3734
    3835    def display_name(self):
  • trunk/WebKitTools/Scripts/webkitpy/tool/main.py

    r73798 r73804  
    4242from webkitpy.common.net.statusserver import StatusServer
    4343from webkitpy.common.system.executive import Executive
    44 from webkitpy.common.system.platform import Platform
     44from webkitpy.common.system.platforminfo import PlatformInfo
    4545from webkitpy.common.system.user import User
    4646from webkitpy.layout_tests import port
     
    7878        self.status_server = StatusServer()
    7979        self.port_factory = port.factory
    80         self.platform = Platform()
     80        self.platform = PlatformInfo()
    8181
    8282    def scm(self):
  • trunk/WebKitTools/Scripts/webkitpy/tool/mocktool.py

    r73798 r73804  
    636636
    637637
    638 class MockPlatform(object):
     638class MockPlatformInfo(object):
    639639    def display_name(self):
    640640        return "MockPlatform 1.0"
     
    655655        self.irc_password = "MOCK irc password"
    656656        self.port_factory = MockPortFactory()
    657         self.platform = MockPlatform()
     657        self.platform = MockPlatformInfo()
    658658
    659659    def scm(self):
Note: See TracChangeset for help on using the changeset viewer.