Changeset 73804 in webkit
- Timestamp:
- Dec 10, 2010 2:30:29 PM (13 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
- 1 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r73798 r73804 1 2010-12-10 Eric Seidel <eric@webkit.org> 2 3 Unreviewed. 4 5 commit-queue should report port/platform information when commenting on flaky test bugs 6 https://bugs.webkit.org/show_bug.cgi?id=50839 7 8 Renamed platform.py to platforminfo.py. This broke import platform in executive.py 9 which was only used by new run webkit tests (and clearly not unit tested). 10 11 * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py. 12 * Scripts/webkitpy/tool/main.py: 13 * Scripts/webkitpy/tool/mocktool.py: 14 1 15 2010-12-10 Eric Seidel <eric@webkit.org> 2 16 -
trunk/WebKitTools/Scripts/webkitpy/common/system/platforminfo.py
r73798 r73804 31 31 32 32 # We use this instead of calls to platform directly so allow mocking. 33 # It's unclear if we should allow instantiation of multiple of these 34 # objects (like we do Ports for rebaseline commands, etc.), 35 # or if it should just be a mocking layer for python's platform.py 36 class Platform(object): 33 class PlatformInfo(object): 37 34 38 35 def display_name(self): -
trunk/WebKitTools/Scripts/webkitpy/tool/main.py
r73798 r73804 42 42 from webkitpy.common.net.statusserver import StatusServer 43 43 from webkitpy.common.system.executive import Executive 44 from webkitpy.common.system.platform import Platform44 from webkitpy.common.system.platforminfo import PlatformInfo 45 45 from webkitpy.common.system.user import User 46 46 from webkitpy.layout_tests import port … … 78 78 self.status_server = StatusServer() 79 79 self.port_factory = port.factory 80 self.platform = Platform ()80 self.platform = PlatformInfo() 81 81 82 82 def scm(self): -
trunk/WebKitTools/Scripts/webkitpy/tool/mocktool.py
r73798 r73804 636 636 637 637 638 class MockPlatform (object):638 class MockPlatformInfo(object): 639 639 def display_name(self): 640 640 return "MockPlatform 1.0" … … 655 655 self.irc_password = "MOCK irc password" 656 656 self.port_factory = MockPortFactory() 657 self.platform = MockPlatform ()657 self.platform = MockPlatformInfo() 658 658 659 659 def scm(self):
Note: See TracChangeset
for help on using the changeset viewer.