Changeset 73884 in webkit

Timestamp:

Dec 12, 2010 8:41:20 PM (13 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: Implement WebInspector::localizedStringsURL on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50896

Reviewed by Tim Hatcher.

Find the localized strings file using CFBundleCopyResourceURL.

• WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL):

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/win/WebInspectorWin.cpp (modified) (2 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-12-12  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Tim Hatcher.
+
+        WebKit2: Implement WebInspector::localizedStringsURL on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=50896
+        
+        Find the localized strings file using CFBundleCopyResourceURL.
+
+        * WebProcess/WebPage/win/WebInspectorWin.cpp:
+        (WebKit::WebInspector::localizedStringsURL):
+
 2010-12-12  Sam Weinig  <sam@webkit.org>
 

trunk/WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp

@@ -28 +28 @@
 #if ENABLE(INSPECTOR)
 
+#include <wtf/RetainPtr.h>
 #include <wtf/text/WTFString.h>
-
-#define DISABLE_NOT_IMPLEMENTED_WARNINGS 1
-#include "NotImplemented.h"
 
 namespace WebKit {
@@ -37 +35 @@
 String WebInspector::localizedStringsURL() const
 {
-    notImplemented();
-    return String();
+    RetainPtr<CFURLRef> localizedStringsURLRef(AdoptCF, CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit")), CFSTR("localizedStrings"), CFSTR("js"), 0));
+    if (!localizedStringsURLRef)
+        return String();
+
+    return String(CFURLGetString(localizedStringsURLRef.get()));
 }