Changeset 73918 in webkit


Ignore:
Timestamp:
Dec 13, 2010 7:53:35 AM (13 years ago)
Author:
mario@webkit.org
Message:

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

New layout test to check the "MoveTo{Beginninng|End}OfDocument"
commands when caret browsing is enabled.

  • platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
  • platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
browsing is enabled.

This change impacts the GTK-port only as caret browsing is a
feature only used in that platform so far.

Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): Enable the commads when in caret browsing.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r73916 r73918  
     12010-12-13  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [Gtk] Additional support is needed for caret browsing
     6        https://bugs.webkit.org/show_bug.cgi?id=25526
     7
     8        New layout test to check the "MoveTo{Beginninng|End}OfDocument"
     9        commands when caret browsing is enabled.
     10
     11        * platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
     12        * platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.
     13
    1142010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
    215
  • trunk/WebCore/ChangeLog

    r73917 r73918  
     12010-12-13  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [Gtk] Additional support is needed for caret browsing
     6        https://bugs.webkit.org/show_bug.cgi?id=25526
     7
     8        Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
     9        browsing is enabled.
     10
     11        This change impacts the GTK-port only as caret browsing is a
     12        feature only used in that platform so far.
     13
     14        Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html
     15
     16        * editing/EditorCommand.cpp:
     17        (WebCore::createCommandMap): Enable the commads when in caret browsing.
     18
    1192010-12-13  Yury Semikhatsky  <yurys@chromium.org>
    220
  • trunk/WebCore/editing/EditorCommand.cpp

    r73621 r73918  
    14581458        { "MoveRight", { executeMoveRight, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14591459        { "MoveRightAndModifySelection", { executeMoveRightAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    1460         { "MoveToBeginningOfDocument", { executeMoveToBeginningOfDocument, supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    1461         { "MoveToBeginningOfDocumentAndModifySelection", { executeMoveToBeginningOfDocumentAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelection, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     1460        { "MoveToBeginningOfDocument", { executeMoveToBeginningOfDocument, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     1461        { "MoveToBeginningOfDocumentAndModifySelection", { executeMoveToBeginningOfDocumentAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14621462        { "MoveToBeginningOfLine", { executeMoveToBeginningOfLine, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14631463        { "MoveToBeginningOfLineAndModifySelection", { executeMoveToBeginningOfLineAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     
    14661466        { "MoveToBeginningOfSentence", { executeMoveToBeginningOfSentence, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14671467        { "MoveToBeginningOfSentenceAndModifySelection", { executeMoveToBeginningOfSentenceAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    1468         { "MoveToEndOfDocument", { executeMoveToEndOfDocument, supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    1469         { "MoveToEndOfDocumentAndModifySelection", { executeMoveToEndOfDocumentAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelection, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     1468        { "MoveToEndOfDocument", { executeMoveToEndOfDocument, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     1469        { "MoveToEndOfDocumentAndModifySelection", { executeMoveToEndOfDocumentAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14701470        { "MoveToEndOfLine", { executeMoveToEndOfLine, supportedFromMenuOrKeyBinding, enabledInEditableTextOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    14711471        { "MoveToEndOfLineAndModifySelection", { executeMoveToEndOfLineAndModifySelection, supportedFromMenuOrKeyBinding, enabledVisibleSelectionOrCaretBrowsing, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
Note: See TracChangeset for help on using the changeset viewer.