Changeset 73929 in webkit

Timestamp:

Dec 13, 2010 10:27:11 AM (13 years ago)

Author:

andersca@apple.com

Message:

Crash when clicking a download link that targets a new tab
​https://bugs.webkit.org/show_bug.cgi?id=50935
<rdar://problem/8760572>

Reviewed by John Sullivan.

Check for a null history item.

• WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURLFromBackForwardList):

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Downloads/mac/DownloadMac.mm (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-12-13  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by John Sullivan.
+
+        Crash when clicking a download link that targets a new tab
+        https://bugs.webkit.org/show_bug.cgi?id=50935
+        <rdar://problem/8760572>
+
+        Check for a null history item.
+
+        * WebProcess/Downloads/mac/DownloadMac.mm:
+        (WebKit::originatingURLFromBackForwardList):
+
 2010-12-13  Andras Becsi  <abecsi@webkit.org>
 

trunk/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm

@@ -69 +69 @@
         // FIXME: At one point we had code here to check a "was user gesture" flag.
         // Do we need to restore that logic?
-        originalURL = page->backForward()->itemAtIndex(-backIndex)->originalURL(); 
+        HistoryItem *historyItem = page->backForward()->itemAtIndex(-backIndex);
+        if (!historyItem)
+            continue;
+
+        originalURL = historyItem->originalURL(); 
         if (!originalURL.isNull()) 
             return originalURL;