Changeset 73935 in webkit

Timestamp:

Dec 13, 2010 11:27:02 AM (13 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: Focusing Web Inspector window doesn't focus contents on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50947
<rdar://problem/8762468>

Reviewed by Darin Adler.

When we get the notification that the inspector window has focused, focus the inner inspector view.

• UIProcess/WebInspectorProxy.h:
• UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onSetFocusEvent): Set the focus of the inspector view, because that is what

needs to be focused in the inspector window.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebInspectorProxy.h (modified) (1 diff)
• UIProcess/win/WebInspectorProxyWin.cpp (modified) (2 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-12-13  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Darin Adler.
+
+        WebKit2: Focusing Web Inspector window doesn't focus contents on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=50947
+        <rdar://problem/8762468>
+        
+        When we get the notification that the inspector window has focused, focus the inner inspector view.
+
+        * UIProcess/WebInspectorProxy.h:
+        * UIProcess/win/WebInspectorProxyWin.cpp:
+        (WebKit::WebInspectorProxy::onSetFocusEvent): Set the focus of the inspector view, because that is what
+            needs to be focused in the inspector window.
+
 2010-12-13  Dan Bernstein  <mitz@apple.com>
 

trunk/WebKit2/UIProcess/WebInspectorProxy.h

@@ -124 +124 @@
     LRESULT onSizeEvent(HWND hWnd, UINT message, WPARAM, LPARAM, bool& handled);
     LRESULT onMinMaxInfoEvent(HWND hWnd, UINT message, WPARAM, LPARAM, bool& handled);
+    LRESULT onSetFocusEvent(HWND hWnd, UINT message, WPARAM, LPARAM, bool& handled);
     LRESULT onCloseEvent(HWND hWnd, UINT message, WPARAM, LPARAM, bool& handled);
 #endif

trunk/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp

@@ -95 +95 @@
         lResult = onMinMaxInfoEvent(hWnd, message, wParam, lParam, handled);
         break;
+    case WM_SETFOCUS:
+        lResult = onSetFocusEvent(hWnd, message, wParam, lParam, handled);
+        break;
     case WM_CLOSE:
         lResult = onCloseEvent(hWnd, message, wParam, lParam, handled);
@@ -115 +118 @@
 
     ::SetWindowPos(m_inspectorView->window(), 0, rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top, SWP_NOZORDER);
+
+    return 0;
+}
+
+LRESULT WebInspectorProxy::onSetFocusEvent(HWND, UINT, WPARAM, LPARAM lParam, bool&)
+{    
+    ::SetFocus(m_inspectorView->window());
 
     return 0;