Changeset 73950 in webkit

Timestamp:

Dec 13, 2010 12:36:22 PM (13 years ago)

Author:

eric@webkit.org

Message:

2010-12-13 Eric Seidel <​eric@webkit.org>

Unreviewed.

Teach webkit-patch how to search bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=50500

webkit-patch bug-search fails when there is only one result.
Turns out we needed a bit more logic in our result count parsing code.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-12-13  Eric Seidel  <eric@webkit.org>
+
+        Unreviewed.
+
+        Teach webkit-patch how to search bugzilla
+        https://bugs.webkit.org/show_bug.cgi?id=50500
+
+        webkit-patch bug-search fails when there is only one result.
+        Turns out we needed a bit more logic in our result count parsing code.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
+
 2010-12-13  Antti Koivisto  <antti@apple.com>
 

trunk/WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -82 +82 @@
     def _parse_result_count(self, results_page):
         result_count_text = BeautifulSoup(results_page).find(attrs={'class': 'bz_result_count'}).string
-        result_count_parts = result_count_text.split(" ")
+        result_count_parts = result_count_text.strip().split(" ")
         if result_count_parts[0] == "Zarro":
             return 0
+        if result_count_parts[0] == "One":
+            return 1
         return int(result_count_parts[0])
 

trunk/WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py

@@ -357 +357 @@
         self._assert_result_count(queries, '<span class="bz_result_count">314 bugs found.</span><span class="bz_result_count">314 bugs found.</span>', 314)
         self._assert_result_count(queries, '<span class="bz_result_count">Zarro Boogs found.</span>', 0)
+        self._assert_result_count(queries, '<span class="bz_result_count">\n \nOne bug found.</span>', 1)
         self.assertRaises(Exception, queries._parse_result_count, ['Invalid'])