Changeset 74001 in webkit

Timestamp:

Dec 13, 2010 9:53:03 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-13 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Daniel Bates.

[skia] ignore transform for canvas shadows
​https://bugs.webkit.org/show_bug.cgi?id=50437

• platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):

Location:

trunk

Files:

• LayoutTests/platform/chromium/test_expectations.txt (modified) (2 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (modified) (3 diffs)

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -2391 +2391 @@
 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.pattern.basic.html = TEXT
 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.pattern.transparent.2.html = TEXT
-BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.transform.2.html = TEXT
 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT
 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT
@@ -3033 +3032 @@
 BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
 
-BUGCR64647 WIN LINUX : fast/canvas/canvas-scale-fillRect-shadow.html = TEXT
-BUGCR64647 WIN LINUX : fast/canvas/canvas-scale-fillPath-shadow.html = TEXT
 BUGCR64647 WIN LINUX : fast/canvas/canvas-scale-strokePath-shadow.html = TEXT
 BUGCR64647 WIN LINUX : fast/canvas/canvas-scale-drawImage-shadow.html = TEXT

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-13  Mike Lawther  <mikelawther@chromium.org>
+
+        Reviewed by Daniel Bates.
+
+        [skia] ignore transform for canvas shadows
+        https://bugs.webkit.org/show_bug.cgi?id=50437
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::GraphicsContext::setPlatformShadow):
+
 2010-12-13  Dai Mikurube  <dmikurube@google.com>
 

trunk/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -1067 +1067 @@
     double blur = blurFloat;
 
-    // TODO(tc): This still does not address the issue that shadows
-    // within canvas elements should ignore transforms.
+    SkBlurDrawLooper::BlurFlags blurFlags = SkBlurDrawLooper::kNone_BlurFlag;
+
     if (m_state.shadowsIgnoreTransforms)  {
         // Currently only the GraphicsContext associated with the
@@ -1074 +1074 @@
         // Transforms. So with this flag set, we know this state is associated
         // with a CanvasRenderingContext.
+        blurFlags = SkBlurDrawLooper::kIgnoreTransform_BlurFlag;
+        
         // CG uses natural orientation for Y axis, but the HTML5 canvas spec
         // does not.
@@ -1089 +1091 @@
     // TODO(tc): Should we have a max value for the blur?  CG clamps at 1000.0
     // for perf reasons.
-    SkDrawLooper* dl = new SkBlurDrawLooper(blur / 2, width, height, c);
+    SkDrawLooper* dl = new SkBlurDrawLooper(blur / 2, width, height, c, blurFlags);
     platformContext()->setDrawLooper(dl);
     dl->unref();