Changeset 74029 in webkit

Timestamp:

Dec 14, 2010 8:57:14 AM (13 years ago)

Author:

cwzwarich@webkit.org

Message:

Reviewed by Eric Seidel.

Clang fails to build the JSC interpreter
​https://bugs.webkit.org/show_bug.cgi?id=51016

Clang does not allow indirect gotos out of scopes with cleanup. GCC 4.2 allows
them, but it does not correctly generate the cleanup, causing a leak if the
cleanup decrements a reference count.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Put an Identifier into its own scope.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/Interpreter.cpp (modified) (1 diff)
• wtf/Platform.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-12-13  Cameron Zwarich  <zwarich@apple.com>
+
+        Reviewed by Eric Seidel.
+
+        Clang fails to build the JSC interpreter
+        https://bugs.webkit.org/show_bug.cgi?id=51016
+
+        Clang does not allow indirect gotos out of scopes with cleanup. GCC 4.2 allows
+        them, but it does not correctly generate the cleanup, causing a leak if the
+        cleanup decrements a reference count.
+
+        * interpreter/Interpreter.cpp:
+        (JSC::Interpreter::privateExecute): Put an Identifier into its own scope.
+
 2010-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/JavaScriptCore/interpreter/Interpreter.cpp

@@ -3197 +3197 @@
             NEXT_INSTRUCTION();
         }
-        Identifier propertyName(callFrame, subscript.toString(callFrame));
-        result = baseValue.get(callFrame, propertyName);
+        {
+            Identifier propertyName(callFrame, subscript.toString(callFrame));
+            result = baseValue.get(callFrame, propertyName);
+        }
         CHECK_FOR_EXCEPTION();
         callFrame->uncheckedR(dst) = result;

trunk/JavaScriptCore/wtf/Platform.h

@@ -974 +974 @@
     && (OS(DARWIN) || !COMPILER(GCC) || GCC_VERSION_AT_LEAST(4,1,0)) \
     && !OS(WINCE)
-#define ENABLE_JIT 1
+#define ENABLE_JIT 0
 #endif