Changeset 74094 in webkit

Timestamp:

Dec 14, 2010 7:06:23 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

2010-12-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Range::extractContents needs more tests
​https://bugs.webkit.org/show_bug.cgi?id=51005

Added a test to ensure Range::extractContents work as expected.

• fast/dom/Range/range-extract-contents-crash-expected.txt: Renamed from LayoutTests/fast/dom/Range/range-extractContents-expected.txt.
• fast/dom/Range/range-extract-contents-crash.html: Renamed from LayoutTests/fast/dom/Range/range-extractContents.html.
• fast/dom/Range/range-extract-contents-expected.txt: Added.
• fast/dom/Range/range-extract-contents.html: Added.
• resources/dump-as-markup.js: (Markup.dump): Don't call node.getElementsByTagName if it doesn't exist.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/dom/Range/range-extract-contents-expected.txt (added)
• fast/dom/Range/range-extract-contents.html (added)
• resources/dump-as-markup.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-14  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Range::extractContents needs more tests
+        https://bugs.webkit.org/show_bug.cgi?id=51005
+
+        Added a test to ensure Range::extractContents work as expected.
+
+        * fast/dom/Range/range-extract-contents-crash-expected.txt: Renamed from LayoutTests/fast/dom/Range/range-extractContents-expected.txt.
+        * fast/dom/Range/range-extract-contents-crash.html: Renamed from LayoutTests/fast/dom/Range/range-extractContents.html.
+        * fast/dom/Range/range-extract-contents-expected.txt: Added.
+        * fast/dom/Range/range-extract-contents.html: Added.
+        * resources/dump-as-markup.js:
+        (Markup.dump): Don't call node.getElementsByTagName if it doesn't exist.
+
 2010-12-14  Jian Li  <jianli@chromium.org>
 

trunk/LayoutTests/resources/dump-as-markup.js

@@ -64 +64 @@
     // FIXME: Have this respect layoutTestController.dumpChildFramesAsText?
     // FIXME: Should we care about framesets?
-    var iframes = node.getElementsByTagName('iframe');
-    for (var i = 0; i < iframes.length; i++) {
-        markup += '\n\nFRAME ' + i + ':\n'
-        try {
-            markup += Markup.get(iframes[i].contentDocument.body.parentElement);
-        } catch (e) {
-            markup += 'FIXME: Add method to layout test controller to get access to cross-origin frames.';
+    // DocumentFragment doesn't have a getElementsByTagName method.
+    if (node.getElementsByTagName) {
+        var iframes = node.getElementsByTagName('iframe');
+        for (var i = 0; i < iframes.length; i++) {
+            markup += '\n\nFRAME ' + i + ':\n'
+            try {
+                markup += Markup.get(iframes[i].contentDocument.body.parentElement);
+            } catch (e) {
+                markup += 'FIXME: Add method to layout test controller to get access to cross-origin frames.';
+            }
         }
     }