Changeset 74096 in webkit

Timestamp:

Dec 14, 2010 7:48:01 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-14 Koan-Sin Tan <​koansin.tan@gmail.com>

Reviewed by Alexey Proskuryakov.

Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
​https://bugs.webkit.org/show_bug.cgi?id=51012

Test if kana displayed correctly in vertical text with broken font.

• fast/blockflow/japanese-rl-text-with-broken-font.html: Added.
• platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
• platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
• platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.

2010-12-14 Koan-Sin Tan <​koansin.tan@gmail.com>

Reviewed by Alexey Proskuryakov.

Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
​https://bugs.webkit.org/show_bug.cgi?id=51012

Kana should be displayed correctly in vertical text with broken font.

Test: fast/blockflow/japanese-rl-text-with-broken-font.html

• platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeographOrSymbol): add katakana, hiraganna, and Halfwidth and Fullwidth Forms

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/blockflow/japanese-rl-text-with-broken-font.html (added)
• LayoutTests/platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum (added)
• LayoutTests/platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png (added)
• LayoutTests/platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/Font.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-14  Koan-Sin Tan  <koansin.tan@gmail.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=51012
+  
+        Test if kana displayed correctly in vertical text with broken font.
+
+        * fast/blockflow/japanese-rl-text-with-broken-font.html: Added.
+        * platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
+        * platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
+        * platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
+
 2010-12-14  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-14  Koan-Sin Tan  <koansin.tan@gmail.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=51012
+
+        Kana should be displayed correctly in vertical text with broken font.
+
+        Test: fast/blockflow/japanese-rl-text-with-broken-font.html
+
+        * platform/graphics/Font.cpp:
+        (WebCore::Font::isCJKIdeographOrSymbol): add katakana, hiraganna, and Halfwidth and Fullwidth Forms
+
 2010-12-14  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/platform/graphics/Font.cpp

@@ -399 +399 @@
         return true;
    
+    // Hiragana 
+    if (c >= 0x3040 && c <= 0x309F)
+        return true;
+
+    // Katakana 
+    if (c >= 0x30A0 && c <= 0x30FF)
+        return true;
+
     // Bopomofo
     if (c >= 0x3100 && c <= 0x312F)
@@ -419 +427 @@
         return true;
 
+    // Halfwidth and Fullwidth Forms
+    // Usually only used in CJK
+    if (c >= 0xFF00 && c <= 0xFFEF)
+        return true;
+
     // Emoji.
     if (c >= 0x1F200 && c <= 0x1F6F)