Changeset 74130 in webkit

Timestamp:

Dec 15, 2010 11:33:05 AM (13 years ago)

Author:

ojan@chromium.org

Message:

2010-12-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[reviewtool] should always show overall comments text box
​https://bugs.webkit.org/show_bug.cgi?id=45870

• PrettyPatch/PrettyPatch.rb:
• code-review.js:

Location:

trunk/BugsSite

Files:

• ChangeLog (modified) (1 diff)
• PrettyPatch/PrettyPatch.rb (modified) (5 diffs)
• code-review.js (modified) (3 diffs)

trunk/BugsSite/ChangeLog

@@ +1 @@
+2010-12-08  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [reviewtool] should always show overall comments text box
+        https://bugs.webkit.org/show_bug.cgi?id=45870
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-12-04  Patrick Gansterer  <paroga@webkit.org>
 

trunk/BugsSite/PrettyPatch/PrettyPatch.rb

@@ -198 +198 @@
 
 .comment textarea, .overallComments textarea {
+  display: block;
   width: 100%;
-  height: 6em;
+  height: 2em;
+}
+
+.overallComments .open {
+  -webkit-transition: height .2s;
+  height: 4em;
+}
+
+#statusBubbleContainer.wrap {
+  display: block;
 }
 
@@ -207 +217 @@
 
 #toolbar {
+  display: -webkit-box;
+  display: -moz-box;
   position: fixed;
-  padding: 5px;
+  padding: 3px;
   bottom: 0;
   left: 0;
@@ -218 +230 @@
 
 #toolbar .actions {
-  float: left;
-}
-
-#toolbar .links {
   float: right;
 }
@@ -278 +286 @@
 }
 
-.description {
-  font-style: italic;
-}
-
-.comment, .overallComments, .previousComment, .frozenComment {
+.comment, .previousComment, .frozenComment {
   background-color: #ffd;
 }
 
 .overallComments {
-  padding: 5px;
+  -webkit-box-flex: 1;
+  -moz-box-flex: 1;
+  margin-right: 3px;
 }
 
@@ -305 +311 @@
 
 .statusBubble {
-  margin-left: 5px;
-  width: 450px;
+  margin-top: 2px;
+  /* FIXME: Size the statusBubble via postMessage so it sizes to it's content. */
+  width: 300px;
   height: 20px;
   border: none;

trunk/BugsSite/code-review.js

@@ -214 +214 @@
   function addFlagsForAttachment(details) {
     var flag_control = "<select><option></option><option>?</option><option>+</option><option>-</option></select>";
-    $('#toolbar .actions').append(
+    $('#flagContainer').append(
       $('<span class="review"> r: ' + flag_control + '</span>')).append(
       $('<span class="commitQueue"> cq: ' + flag_control + '</span>'));
@@ -248 +248 @@
       var details = $(data);
       addFlagsForAttachment(details);
-      $('#toolbar .actions').append($('<iframe class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));
+      $('#statusBubbleContainer').append($('<iframe style="margin-top:2px;" class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));
       $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
     });
@@ -261 +261 @@
   }
 
+  function openOverallComments(e) {
+    $('.overallComments textarea').addClass('open');
+    $('#statusBubbleContainer').addClass('wrap');
+  }
+
   $(document).ready(function() {
     crawlDiff();
     fetchHistory();
     $(document.body).prepend('<div id="message"><div class="help">Select line numbers to add a comment.</div><div class="commentStatus"></div></div>');
-    $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="preview_comments">Preview</button><button id="post_comments">Publish</button></div><div class="links"><span class="bugLink"></span></div>');
+    $(document.body).prepend('<div id="toolbar">' +
+        '<div class="overallComments">' +
+            '<textarea placeholder="Overall comments"></textarea>' +
+        '</div>' +
+        '<div>' +
+          '<span id="statusBubbleContainer"></span>' +
+          '<span class="actions">' +
+              '<span class="links"><span class="bugLink"></span></span>' +
+              '<span id="flagContainer"></span>' +
+              '<button id="preview_comments">Preview</button>' +
+              '<button id="post_comments">Publish</button> ' +
+          '</span></div>' +
+        '</div>' +
+        '</div>');
+
+    $('.overallComments textarea').bind('click', openOverallComments);
+
     $(document.body).prepend('<div id="comment_form" class="inactive"><div class="winter"></div><div class="lightbox"><iframe id="reviewform" src="attachment.cgi?id=' + attachment_id + '&action=reviewform"></iframe></div></div>');
-    $(document.body).append('<div class="overallComments"><div class="description">Overall comments:</div><textarea></textarea></div>');
   });