Changeset 74153 in webkit

Timestamp:

Dec 15, 2010 3:41:22 PM (13 years ago)

Author:

timothy@apple.com

Message:

Fix a regression where the Web Inspector console would be empty
if the Inspector is localized.

​https://bugs.webkit.org/show_bug.cgi?id=51145

Reviewed by Joseph Pecoraro.

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.createFilterElement): Add a label argument so the UI string
is separate from the classname. Code clean up.
(WebInspector.ConsoleView.prototype.filter): Remove toLowerCase and use string compare.
(WebInspector.ConsoleView): Pass separate classnames and labels to createFilterElement.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-15  Timothy Hatcher  <timothy@apple.com>
+
+        Fix a regression where the Web Inspector console would be empty
+        if the Inspector is localized.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51145
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.createFilterElement): Add a label argument so the UI string
+        is separate from the classname. Code clean up.
+        (WebInspector.ConsoleView.prototype.filter): Remove toLowerCase and use string compare.
+        (WebInspector.ConsoleView): Pass separate classnames and labels to createFilterElement.
+
 2010-12-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/inspector/front-end/ConsoleView.js

@@ -69 +69 @@
 
     var updateFilterHandler = this._updateFilter.bind(this);
-    function createFilterElement(category) {
+    function createFilterElement(category, label) {
         var categoryElement = document.createElement("li");
         categoryElement.category = category;
-        categoryElement.addStyleClass(categoryElement.category);
+        categoryElement.className = category;
         categoryElement.addEventListener("click", updateFilterHandler, false);
-
-        var label = category.toString();
-        categoryElement.appendChild(document.createTextNode(label));
+        categoryElement.textContent = label;
 
         this.filterBarElement.appendChild(categoryElement);
+
         return categoryElement;
     }
 
-    this.allElement = createFilterElement.call(this, WebInspector.UIString("All"));
+    this.allElement = createFilterElement.call(this, "all", WebInspector.UIString("All"));
     createDividerElement.call(this);
-    this.errorElement = createFilterElement.call(this, WebInspector.UIString("Errors"));
-    this.warningElement = createFilterElement.call(this, WebInspector.UIString("Warnings"));
-    this.logElement = createFilterElement.call(this, WebInspector.UIString("Logs"));
+    this.errorElement = createFilterElement.call(this, "errors", WebInspector.UIString("Errors"));
+    this.warningElement = createFilterElement.call(this, "warnings", WebInspector.UIString("Warnings"));
+    this.logElement = createFilterElement.call(this, "logs", WebInspector.UIString("Logs"));
 
     this.filter(this.allElement, false);
@@ -129 +128 @@
         }
 
-        var targetFilterClass = "filter-" + target.category.toLowerCase();
-
-        if (target.category == "All") {
+        var targetFilterClass = "filter-" + target.category;
+
+        if (target.category === "all") {
             if (target.hasStyleClass("selected")) {
                 // We can't unselect all, so we break early here