Changeset 74192 in webkit


Ignore:
Timestamp:
Dec 16, 2010 8:32:14 AM (13 years ago)
Author:
ariya@webkit.org
Message:

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[JSC] Const correctness in ASTBuilder and SyntaxChecker
https://bugs.webkit.org/show_bug.cgi?id=51141

  • parser/ASTBuilder.h: (JSC::ASTBuilder::getName): (JSC::ASTBuilder::getType): (JSC::ASTBuilder::isResolve):
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::operatorStackPop):
Location:
trunk/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r74147 r74192  
     12010-12-16  Ariya Hidayat  <ariya@sencha.com>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [JSC] Const correctness in ASTBuilder and SyntaxChecker
     6        https://bugs.webkit.org/show_bug.cgi?id=51141
     7
     8        * parser/ASTBuilder.h:
     9        (JSC::ASTBuilder::getName):
     10        (JSC::ASTBuilder::getType):
     11        (JSC::ASTBuilder::isResolve):
     12        * parser/SyntaxChecker.h:
     13        (JSC::SyntaxChecker::operatorStackPop):
     14
    1152010-12-15  Kenneth Russell  <kbr@google.com>
    216
  • trunk/JavaScriptCore/parser/ASTBuilder.h

    r69516 r74192  
    577577    }
    578578   
    579     const Identifier& getName(Property property) { return property->name(); }
    580     PropertyNode::Type getType(Property property) { return property->type(); }
    581 
    582     bool isResolve(ExpressionNode* expr) { return expr->isResolveNode(); }
     579    const Identifier& getName(Property property) const { return property->name(); }
     580    PropertyNode::Type getType(Property property) const { return property->type(); }
     581
     582    bool isResolve(ExpressionNode* expr) const { return expr->isResolveNode(); }
    583583
    584584private:
  • trunk/JavaScriptCore/parser/SyntaxChecker.h

    r69516 r74192  
    204204    void assignmentStackAppend(int, int, int, int, int, Operator) { }
    205205    int createAssignment(int, int, int, int, int) { ASSERT_NOT_REACHED(); return 1; }
    206     const Identifier& getName(const Property& property) { ASSERT(property.name); return *property.name; }
    207     PropertyNode::Type getType(const Property& property) { return property.type; }
    208     bool isResolve(ExpressionType expr) { return expr == ResolveExpr || expr == ResolveEvalExpr; }
     206    const Identifier& getName(const Property& property) const { ASSERT(property.name); return *property.name; }
     207    PropertyNode::Type getType(const Property& property) const { return property.type; }
     208    bool isResolve(ExpressionType expr) const { return expr == ResolveExpr || expr == ResolveEvalExpr; }
    209209   
    210210private:
Note: See TracChangeset for help on using the changeset viewer.