Changeset 74204 in webkit


Ignore:
Timestamp:
Dec 16, 2010 12:01:57 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

2010-12-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
​https://bugs.webkit.org/show_bug.cgi?id=51164

Fixed the bug by always enabling the StyleWithCSS command.

Test: editing/style/stylewithcss-without-selection.html

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.

2010-12-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
​https://bugs.webkit.org/show_bug.cgi?id=51164

Added a test to ensure WebKit accepts StyleWithCSS command even if the current selection
isn't inside a contenteditable region.

  • editing/style/stylewithcss-without-selection-expected.txt: Added.
  • editing/style/stylewithcss-without-selection.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r74195 r74204  
     12010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
     6        https://bugs.webkit.org/show_bug.cgi?id=51164
     7
     8        Added a test to ensure WebKit accepts StyleWithCSS command even if the current selection
     9        isn't inside a contenteditable region.
     10
     11        * editing/style/stylewithcss-without-selection-expected.txt: Added.
     12        * editing/style/stylewithcss-without-selection.html: Added.
     13
    1142010-12-16  Andrew Scherkus  <scherkus@chromium.org>
    215

  • trunk/WebCore/ChangeLog

    r74202 r74204  
     12010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
     6        https://bugs.webkit.org/show_bug.cgi?id=51164
     7
     8        Fixed the bug by always enabling the StyleWithCSS command.
     9
     10        Test: editing/style/stylewithcss-without-selection.html
     11
     12        * editing/EditorCommand.cpp:
     13        (WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.
     14
    1152010-12-16  Anders Carlsson  <andersca@apple.com>
    216

  • trunk/WebCore/editing/EditorCommand.cpp

    r73918 r74204  
    15031503        { "SetMark", { executeSetMark, supportedFromMenuOrKeyBinding, enabledVisibleSelection, stateNone, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    15041504        { "Strikethrough", { executeStrikethrough, supported, enabledInRichlyEditableText, stateStrikethrough, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    1505         { "StyleWithCSS", { executeStyleWithCSS, supported, enabledInRichlyEditableText, stateStyleWithCSS, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
     1505        { "StyleWithCSS", { executeStyleWithCSS, supported, enabled, stateStyleWithCSS, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    15061506        { "Subscript", { executeSubscript, supported, enabledInRichlyEditableText, stateSubscript, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
    15071507        { "Superscript", { executeSuperscript, supported, enabledInRichlyEditableText, stateSuperscript, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },
Note: See TracChangeset for help on using the changeset viewer.