Changeset 74251 in webkit

Timestamp:

Dec 17, 2010 4:46:10 AM (13 years ago)

Author:

sergio@webkit.org

Message:

2010-12-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

Wrong check in ResourceHandleSoup in error cases
​https://bugs.webkit.org/show_bug.cgi?id=51171

Calling didReceiveData with no data causes a crash in debug
builds. Checking for soupMsg->response_body->data is not correct as libsoup
always creates a buffer for that. Instead we should check for
soupMsg->response_body->length

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-16  Sergio Villar Senin  <svillar@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        Wrong check in ResourceHandleSoup in error cases
+        https://bugs.webkit.org/show_bug.cgi?id=51171
+
+        Calling didReceiveData with no data causes a crash in debug
+        builds. Checking for soupMsg->response_body->data is not correct as libsoup
+        always creates a buffer for that. Instead we should check for
+        soupMsg->response_body->length
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::sendRequestCallback):
+
 2010-12-17  Andreas Kling  <andreas.kling@nokia.com>
 

trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -509 +509 @@
             client->didReceiveResponse(handle.get(), d->m_response);
 
-            // WebCore might have cancelled the job in the while
-            if (!d->m_cancelled && soupMsg->response_body->data)
+            // WebCore might have cancelled the job in the while. We
+            // must check for response_body->length and not
+            // response_body->data as libsoup always creates the
+            // SoupBuffer for the body even if the length is 0
+            if (!d->m_cancelled && soupMsg->response_body->length)
                 client->didReceiveData(handle.get(), soupMsg->response_body->data, soupMsg->response_body->length, true);
         }