Changeset 74269 in webkit


Ignore:
Timestamp:
Dec 17, 2010 8:15:41 AM (13 years ago)
Author:
tonikitoo@webkit.org
Message:

2010-12-16 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
https://bugs.webkit.org/show_bug.cgi?id=51163

WebKitTools:
Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
GTK+'s DRT should also reset to UNIX after each test execution.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

LayoutTests:
Removed platform specific expected result files for gtk and windows
for editing/selection/extend-selection-home-end.html, since they all match
the cross platform result file.

Note: chromium-win and mac still have their own expected file each.

  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
Location:
trunk
Files:
2 deleted
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r74267 r74269  
     12010-12-16  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
     6        https://bugs.webkit.org/show_bug.cgi?id=51163
     7
     8        Removed platform specific expected result files for gtk and windows
     9        for editing/selection/extend-selection-home-end.html, since they all match
     10        the cross platform result file.
     11
     12        Note: chromium-win and mac still have their own expected file each.
     13
     14        * platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
     15        * platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
     16
    1172010-12-17  Yury Semikhatsky  <yurys@chromium.org>
    218
  • trunk/WebKitTools/ChangeLog

    r74255 r74269  
     12010-12-16  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
     6        https://bugs.webkit.org/show_bug.cgi?id=51163
     7
     8        Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
     9        GTK+'s DRT should also reset to UNIX after each test execution.
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (resetDefaultsToConsistentValues):
     13
    1142010-12-17  David Levin  <levin@chromium.org>
    215
  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r73695 r74269  
    416416                 "enable-plugins", TRUE,
    417417                 "enable-hyperlink-auditing", FALSE,
    418                  "editing-behavior", WEBKIT_EDITING_BEHAVIOR_MAC,
     418                 "editing-behavior", WEBKIT_EDITING_BEHAVIOR_UNIX,
    419419                 "enable-fullscreen", TRUE,
    420420                 NULL);
Note: See TracChangeset for help on using the changeset viewer.