Changeset 74372 in webkit


Ignore:
Timestamp:
Dec 20, 2010 3:37:11 PM (13 years ago)
Author:
andreip@google.com
Message:

2010-12-20 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
​https://bugs.webkit.org/show_bug.cgi?id=51338

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:

2010-12-20 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
​https://bugs.webkit.org/show_bug.cgi?id=51338

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Reader::readUint32):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r74370 r74372  
     12010-12-20  Andrei Popescu  <andreip@google.com>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
     6        https://bugs.webkit.org/show_bug.cgi?id=51338
     7
     8        * fast/dom/Window/window-postmessage-args-expected.txt:
     9        * fast/dom/Window/window-postmessage-args.html:
     10        * platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
     11        * platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:
     12
    1132010-12-20  Beth Dakin  <bdakin@apple.com>
    214

  • trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt

    r48025 r74372  
    88PASS: Posting message ('6', undefined) did not throw an exception
    99PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
     10PASS: Posting message ('2147483648', null) did not throw an exception
    1011PASS: Posting message ('done', *) did not throw an exception
    1112Received message '4'
    … …  
    1314Received message '6'
    1415Received message '7' with 2 ports.
     16Received message '2147483648'
    1517Received message 'done'
    1618

  • trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html

    r48025 r74372  
    4646tryPostMessage('6', void 0, '*');
    4747tryPostMessage('7', [channel.port1, channel.port2], '*');
     48tryPostMessage(2147483648, null, '*');
    4849tryPostMessage('done', '*');
    4950</script>

  • trunk/LayoutTests/platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt

    r74097 r74372  
    88PASS: Posting message ('6', undefined) did not throw an exception
    99PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
     10PASS: Posting message ('2147483648', null) did not throw an exception
    1011PASS: Posting message ('done', *) did not throw an exception
    1112Received message '4'
    … …  
    1314Received message '6'
    1415Received message '7' with 2 ports.
     16Received message '2147483648'
    1517Received message 'done'
    1618

  • trunk/LayoutTests/platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt

    r74097 r74372  
    88PASS: Posting message ('6', undefined) did not throw an exception
    99PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
     10PASS: Posting message ('2147483648', null) did not throw an exception
    1011PASS: Posting message ('done', *) did not throw an exception
    1112Received message '4'
    … …  
    1314Received message '6'
    1415Received message '7' with 2 ports.
     16Received message '2147483648'
    1517Received message 'done'
    1618

  • trunk/WebCore/ChangeLog

    r74370 r74372  
     12010-12-20  Andrei Popescu  <andreip@google.com>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
     6        https://bugs.webkit.org/show_bug.cgi?id=51338
     7
     8        * bindings/v8/SerializedScriptValue.cpp:
     9        (WebCore::ZigZag::Reader::readUint32):
     10
    1112010-12-20  Beth Dakin  <bdakin@apple.com>
    212

  • trunk/WebCore/bindings/v8/SerializedScriptValue.cpp

    r70851 r74372  
    845845        if (!doReadUint32(&rawValue))
    846846            return false;
    847         *value = v8::Integer::New(rawValue);
     847        *value = v8::Integer::NewFromUnsigned(rawValue);
    848848        return true;
    849849    }
Note: See TracChangeset for help on using the changeset viewer.