Changeset 74397 in webkit

Timestamp:

Dec 20, 2010 11:11:50 PM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2010-12-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: cycle through tag name / attributes / new attribute on Tab.

​https://bugs.webkit.org/show_bug.cgi?id=38429

• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-20  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Joseph Pecoraro.
+
+        Web Inspector: cycle through tag name / attributes / new attribute on Tab.
+
+        https://bugs.webkit.org/show_bug.cgi?id=38429
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
+
 2010-12-20  Yuta Kitamura  <yutak@chromium.org>
 

trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -1034 +1034 @@
                 if (moveDirection === "backward" && attributes.length > 0)
                     moveToAttribute = attributes[attributes.length - 1].name;
-                else if (moveDirection === "forward" && !/^\s*$/.test(newText))
-                    moveToNewAttribute = true;
+                else if (moveDirection === "forward") {
+                    if (!/^\s*$/.test(newText))
+                        moveToNewAttribute = true;
+                    else
+                        moveToTagName = true;
+                }
             }
         }
@@ -1113 +1117 @@
         function moveToNextAttributeIfNeeded()
         {
-            if (moveDirection !== "forward")
+            if (moveDirection !== "forward") {
+                this._addNewAttribute();
                 return;
+            }
 
             var attributes = this.representedObject.attributes;