Changeset 74404 in webkit

Timestamp:

Dec 20, 2010 11:50:15 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-20 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

Qt port of geolocation, geoposition objects timestamp was in seconds
instead of miliseconds as per HTML5 Geolocation standards.
Ref: ​http://dev.w3.org/geo/api/spec-source.html#position_interface
​http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp

Implemented by Asheesh Srivastava.

[QT] QtWebkit geolocation's position.timestamp is not in miliseconds
​https://bugs.webkit.org/show_bug.cgi?id=51100

Porting code not covered in layout testing. No new tests added.

• platform/qt/GeolocationServiceQt.cpp: (WebCore::GeolocationServiceQt::positionUpdated):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/GeolocationServiceQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-20  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        Qt port of geolocation, geoposition objects timestamp was in seconds
+        instead of miliseconds as per HTML5 Geolocation standards.
+        Ref: http://dev.w3.org/geo/api/spec-source.html#position_interface 
+        http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp 
+
+        Implemented by Asheesh Srivastava.
+
+        [QT] QtWebkit geolocation's position.timestamp is not in miliseconds
+        https://bugs.webkit.org/show_bug.cgi?id=51100
+
+        Porting code not covered in layout testing. No new tests added.
+
+        * platform/qt/GeolocationServiceQt.cpp:
+        (WebCore::GeolocationServiceQt::positionUpdated):
+
 2010-12-20  Yuzo Fujishima  <yuzo@google.com>
 

trunk/WebCore/platform/qt/GeolocationServiceQt.cpp

@@ -84 +84 @@
                                                           accuracy, providesAltitudeAccuracy, altitudeAccuracy,
                                                           providesHeading, heading, providesSpeed, speed);
-    m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toTime_t());
+
+#if QT_VERSION >= QT_VERSION_CHECK(4, 7, 0)
+    m_lastPosition = Geoposition::create(coordinates.release(), geoPosition.timestamp().toMSecsSinceEpoch());
+#else
+    QDateTime timestamp = geoPosition.timestamp();
+    m_lastPosition = Geoposition::create(coordinates.release(), (timestamp.toTime_t() * 1000.00) + timestamp.time().msec());
+#endif
     positionChanged();
 }