Changeset 74480 in webkit

Timestamp:

Dec 22, 2010 8:22:58 AM (13 years ago)

Author:

loislo@chromium.org

Message:

2010-12-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.

DevTools window should be closed explicitly because it has custom deinitialization code.

​https://bugs.webkit.org/show_bug.cgi?id=50722

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeRemainingWindows):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/TestShell.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
+
+        DevTools window should be closed explicitly because it has custom deinitialization code.
+
+        https://bugs.webkit.org/show_bug.cgi?id=50722
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::closeRemainingWindows):
+
 2010-12-22  David Levin  <levin@chromium.org>
 

trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

@@ -599 +599 @@
 void TestShell::closeRemainingWindows()
 {
+    // Just close devTools window manually because we have custom deinitialization code for it.
+    closeDevTools();
+
     // Iterate through the window list and close everything except the main
     // window. We don't want to delete elements as we're iterating, so we copy