Changeset 74628 in webkit

Timestamp:

Dec 24, 2010 3:50:34 AM (13 years ago)

Author:

evan@chromium.org

Message:

2010-12-24 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

TextMetrics::width is an integer, but the member is a float
​https://bugs.webkit.org/show_bug.cgi?id=51566

Change the return type to a float.

No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)

• html/TextMetrics.h: (WebCore::TextMetrics::width):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/TextMetrics.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-24  Evan Martin  <evan@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        TextMetrics::width is an integer, but the member is a float
+        https://bugs.webkit.org/show_bug.cgi?id=51566
+
+        Change the return type to a float.
+
+        No tests, fixing a compiler warning.
+        (I was unable to produce a difference in the values exposed to pages
+        with a float versus the previous conversion to an integer.)
+
+        * html/TextMetrics.h:
+        (WebCore::TextMetrics::width):
+
 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/WebCore/html/TextMetrics.h

@@ -36 +36 @@
     static PassRefPtr<TextMetrics> create() { return adoptRef(new TextMetrics); }
 
-    // FIXME: Is coercing to an integer value intentional? If so, there should be a static_cast<unsigned>() here.
-    unsigned width() const { return m_width; }
+    float width() const { return m_width; }
     void setWidth(float w) { m_width = w; }