Changeset 74681 in webkit


Ignore:
Timestamp:
Dec 27, 2010 6:10:57 AM (13 years ago)
Author:
yael.aharon@nokia.com
Message:

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Update the expected result for the test.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.

No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.

  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r74680 r74681  
     12010-12-27  Yael Aharon  <yael.aharon@nokia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Browser is failing 16 baseline test from Selector API Test Suite
     6        https://bugs.webkit.org/show_bug.cgi?id=42968
     7
     8        Update the expected result for the test.
     9
     10        * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
     11
    1122010-12-27  Shinichiro Hamaji  <shinichiro.hamaji@gmail.com>
    213
  • trunk/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt

    r41114 r74681  
    55 Show only failing tests.
    66
    7 99.2%: 2147 passed, 17 failed
     7100.0%: 2163 passed, 1 failed
    88PASS Element supports querySelector
    99PASS Element supports querySelectorAll
     
    1111PASS Element.querySelectorAll null
    1212PASS Element.querySelectorAll undefined
    13 FAIL Element.querySelectorAll no value
     13PASS Element.querySelectorAll no value
    1414PASS Element.querySelector Empty String
    1515PASS Element.querySelector null
    1616PASS Element.querySelector undefined
    17 FAIL Element.querySelector no value
     17PASS Element.querySelector no value
    1818PASS Element.querySelectorAll: .target :target
    1919PASS Element.querySelectorAll Whitespace Trim: .target :target
     
    551551PASS Syntax Error: Element.querySelectorAll null
    552552PASS Syntax Error: Element.querySelectorAll undefined
    553 FAIL Syntax Error: Element.querySelectorAll no value
     553PASS Syntax Error: Element.querySelectorAll no value
    554554PASS Syntax Error: Element.querySelector Empty String
    555555PASS Syntax Error: Element.querySelector null
    556556PASS Syntax Error: Element.querySelector undefined
    557 FAIL Syntax Error: Element.querySelector no value
     557PASS Syntax Error: Element.querySelector no value
    558558PASS Syntax Error: Element.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
    559559PASS Syntax Error: Element.querySelector: .blox16:not(.blox15[foo="blox14"])
     
    727727PASS Disconnected Element.querySelectorAll null
    728728PASS Disconnected Element.querySelectorAll undefined
    729 FAIL Disconnected Element.querySelectorAll no value
     729PASS Disconnected Element.querySelectorAll no value
    730730PASS Disconnected Element.querySelector Empty String
    731731PASS Disconnected Element.querySelector null
    732732PASS Disconnected Element.querySelector undefined
    733 FAIL Disconnected Element.querySelector no value
     733PASS Disconnected Element.querySelector no value
    734734PASS Disconnected Element.querySelectorAll: .target :target
    735735PASS Disconnected Element.querySelectorAll Whitespace Trim: .target :target
     
    11491149PASS Syntax Error: Disconnected Element.querySelectorAll null
    11501150PASS Syntax Error: Disconnected Element.querySelectorAll undefined
    1151 FAIL Syntax Error: Disconnected Element.querySelectorAll no value
     1151PASS Syntax Error: Disconnected Element.querySelectorAll no value
    11521152PASS Syntax Error: Disconnected Element.querySelector Empty String
    11531153PASS Syntax Error: Disconnected Element.querySelector null
    11541154PASS Syntax Error: Disconnected Element.querySelector undefined
    1155 FAIL Syntax Error: Disconnected Element.querySelector no value
     1155PASS Syntax Error: Disconnected Element.querySelector no value
    11561156PASS Syntax Error: Disconnected Element.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
    11571157PASS Syntax Error: Disconnected Element.querySelector: .blox16:not(.blox15[foo="blox14"])
     
    13251325PASS Fragment.querySelectorAll null
    13261326PASS Fragment.querySelectorAll undefined
    1327 FAIL Fragment.querySelectorAll no value
     1327PASS Fragment.querySelectorAll no value
    13281328PASS Fragment.querySelector Empty String
    13291329PASS Fragment.querySelector null
    13301330PASS Fragment.querySelector undefined
    1331 FAIL Fragment.querySelector no value
     1331PASS Fragment.querySelector no value
    13321332PASS Fragment.querySelectorAll: .target :target
    13331333PASS Fragment.querySelectorAll Whitespace Trim: .target :target
     
    16301630PASS Syntax Error: Fragment.querySelectorAll null
    16311631PASS Syntax Error: Fragment.querySelectorAll undefined
    1632 FAIL Syntax Error: Fragment.querySelectorAll no value
     1632PASS Syntax Error: Fragment.querySelectorAll no value
    16331633PASS Syntax Error: Fragment.querySelector Empty String
    16341634PASS Syntax Error: Fragment.querySelector null
    16351635PASS Syntax Error: Fragment.querySelector undefined
    1636 FAIL Syntax Error: Fragment.querySelector no value
     1636PASS Syntax Error: Fragment.querySelector no value
    16371637PASS Syntax Error: Fragment.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
    16381638PASS Syntax Error: Fragment.querySelector: .blox16:not(.blox15[foo="blox14"])
     
    16881688PASS Document.querySelectorAll null
    16891689PASS Document.querySelectorAll undefined
    1690 FAIL Document.querySelectorAll no value
     1690PASS Document.querySelectorAll no value
    16911691PASS Document.querySelector Empty String
    16921692PASS Document.querySelector null
    16931693PASS Document.querySelector undefined
    1694 FAIL Document.querySelector no value
     1694PASS Document.querySelector no value
    16951695PASS Document.querySelectorAll: .target :target
    16961696PASS Document.querySelectorAll Whitespace Trim: .target :target
     
    19931993PASS Syntax Error: Document.querySelectorAll null
    19941994PASS Syntax Error: Document.querySelectorAll undefined
    1995 FAIL Syntax Error: Document.querySelectorAll no value
     1995PASS Syntax Error: Document.querySelectorAll no value
    19961996PASS Syntax Error: Document.querySelector Empty String
    19971997PASS Syntax Error: Document.querySelector null
    19981998PASS Syntax Error: Document.querySelector undefined
    1999 FAIL Syntax Error: Document.querySelector no value
     1999PASS Syntax Error: Document.querySelector no value
    20002000PASS Syntax Error: Document.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
    20012001PASS Syntax Error: Document.querySelector: .blox16:not(.blox15[foo="blox14"])
  • trunk/WebCore/ChangeLog

    r74673 r74681  
     12010-12-27  Yael Aharon  <yael.aharon@nokia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Browser is failing 16 baseline test from Selector API Test Suite
     6        https://bugs.webkit.org/show_bug.cgi?id=42968
     7
     8        Throw an exception if there is no argument to querySelector or
     9        querySelectorAll. This replaces the current behavior of passing the string
     10        "undefined" as the argument.
     11
     12        No new tests, just updating the existing results for
     13        fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
     14
     15        * dom/Document.idl:
     16        * dom/DocumentFragment.idl:
     17        * dom/Element.idl:
     18
    1192010-12-26  MORITA Hajime  <morrita@google.com>
    220
  • trunk/WebCore/dom/Document.idl

    r71813 r74681  
    232232
    233233        // NodeSelector - Selector API
    234         Element querySelector(in DOMString selectors)
    235             raises(DOMException);
    236         NodeList querySelectorAll(in DOMString selectors)
     234        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
     235            raises(DOMException);
     236        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
    237237            raises(DOMException);
    238238
  • trunk/WebCore/dom/DocumentFragment.idl

    r52921 r74681  
    2222    interface DocumentFragment : Node {
    2323        // NodeSelector - Selector API
    24         Element querySelector(in DOMString selectors)
     24        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
    2525            raises(DOMException);
    26         NodeList querySelectorAll(in DOMString selectors)
     26        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
    2727            raises(DOMException);
    2828    };
  • trunk/WebCore/dom/Element.idl

    r66467 r74681  
    105105
    106106        // NodeSelector - Selector API
    107         Element querySelector(in DOMString selectors)
    108             raises(DOMException);
    109         NodeList querySelectorAll(in DOMString selectors)
     107        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
     108            raises(DOMException);
     109        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
    110110            raises(DOMException);
    111111
Note: See TracChangeset for help on using the changeset viewer.