Changeset 74801 in webkit
- Timestamp:
- Dec 30, 2010 11:31:00 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r74796 r74801 1 2010-12-30 Yael Aharon <yael.aharon@nokia.com> 2 3 Reviewed by Adam Barth. 4 5 REGRESSION: fast/dom/cssTarget-crash.html fails 6 https://bugs.webkit.org/show_bug.cgi?id=20342 7 8 * fast/forms/submit-change-fragment-expected.txt: Added. 9 * fast/forms/submit-change-fragment.html: Added. 10 * platform/mac/Skipped: 11 * platform/qt/Skipped: 12 1 13 2010-12-30 Philippe Normand <pnormand@igalia.com> 2 14 -
trunk/LayoutTests/platform/mac/Skipped
r74270 r74801 35 35 # Skip because fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was reverted 36 36 compositing/animation/animated-composited-inside-hidden.html 37 38 # https://bugs.webkit.org/show_bug.cgi?id=20342 REGRESSION: fast/dom/cssTarget-crash.html fails39 fast/dom/cssTarget-crash.html40 37 41 38 # https://bugs.webkit.org/show_bug.cgi?id=21916 Pixel test doesn't repaint entire view so result is corrupted by previous test -
trunk/LayoutTests/platform/qt/Skipped
r74789 r74801 2514 2514 fast/events/5056619.html 2515 2515 fast/events/drag-in-frames.html 2516 fast/dom/cssTarget-crash.html2517 2516 fast/loader/null-request-after-willSendRequest.html 2518 2517 fast/text/international/thai-line-breaks.html -
trunk/WebCore/ChangeLog
r74800 r74801 1 2010-12-30 Yael Aharon <yael.aharon@nokia.com> 2 3 Reviewed by Adam Barth. 4 5 REGRESSION: fast/dom/cssTarget-crash.html fails 6 https://bugs.webkit.org/show_bug.cgi?id=20342 7 8 Do not reload the page when submitting a form, using "GET" method, and the 9 form action url matches the location url, except for the fragment. 10 11 Test: fast/forms/submit-change-fragment.html 12 13 * loader/FrameLoader.cpp: 14 (WebCore::FrameLoader::loadURL): 15 (WebCore::FrameLoader::loadWithDocumentLoader): 16 (WebCore::FrameLoader::shouldScrollToAnchor): 17 * loader/FrameLoader.h: 18 1 19 2010-12-30 Darin Adler <darin@apple.com> 2 20 -
trunk/WebCore/loader/FrameLoader.cpp
r74426 r74801 1320 1320 1321 1321 bool sameURL = shouldTreatURLAsSameAsCurrent(newURL); 1322 const String& httpMethod = request.httpMethod(); 1322 1323 1323 1324 // Make sure to do scroll to anchor processing even if the URL is 1324 1325 // exactly the same so pages with '#' links and DHTML side effects 1325 1326 // work properly. 1326 if (shouldScrollToAnchor(isFormSubmission, newLoadType, newURL)) {1327 if (shouldScrollToAnchor(isFormSubmission, httpMethod, newLoadType, newURL)) { 1327 1328 oldDocumentLoader->setTriggeringAction(action); 1328 1329 policyChecker()->stopCheck(); … … 1443 1444 1444 1445 const KURL& newURL = loader->request().url(); 1445 1446 if (shouldScrollToAnchor(isFormSubmission, policyChecker()->loadType(), newURL)) { 1446 const String& httpMethod = loader->request().httpMethod(); 1447 1448 if (shouldScrollToAnchor(isFormSubmission, httpMethod, policyChecker()->loadType(), newURL)) { 1447 1449 RefPtr<DocumentLoader> oldDocumentLoader = m_documentLoader; 1448 1450 NavigationAction action(newURL, policyChecker()->loadType(), isFormSubmission); … … 2819 2821 } 2820 2822 2821 bool FrameLoader::shouldScrollToAnchor(bool isFormSubmission, FrameLoadType loadType, const KURL& url)2823 bool FrameLoader::shouldScrollToAnchor(bool isFormSubmission, const String& httpMethod, FrameLoadType loadType, const KURL& url) 2822 2824 { 2823 2825 // Should we do anchor navigation within the existing content? 2824 2826 2825 // We don't do this if we are submitting a form , explicitly reloading,2827 // We don't do this if we are submitting a form with method other than "GET", explicitly reloading, 2826 2828 // currently displaying a frameset, or if the URL does not have a fragment. 2827 2829 // These rules were originally based on what KHTML was doing in KHTMLPart::openURL. … … 2829 2831 // FIXME: What about load types other than Standard and Reload? 2830 2832 2831 return !isFormSubmission2833 return (!isFormSubmission || equalIgnoringCase(httpMethod, "GET")) 2832 2834 && loadType != FrameLoadTypeReload 2833 2835 && loadType != FrameLoadTypeReloadFromOrigin -
trunk/WebCore/loader/FrameLoader.h
r73486 r74801 367 367 void continueFragmentScrollAfterNavigationPolicy(const ResourceRequest&, bool shouldContinue); 368 368 369 bool shouldScrollToAnchor(bool isFormSubmission, FrameLoadType, const KURL&);369 bool shouldScrollToAnchor(bool isFormSubmission, const String& httpMethod, FrameLoadType, const KURL&); 370 370 371 371 void checkLoadCompleteForThisFrame();
Note: See TracChangeset
for help on using the changeset viewer.