Changeset 74957 in webkit

Timestamp:

Jan 3, 2011 10:20:17 PM (13 years ago)

Author:

ddkilzer@apple.com

Message:

WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <​Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.

new test:fast/html/object-border.html

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <​Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

• fast/html/object-border-expected.txt: Added.
• fast/html/object-border.html: Added.
• fast/html/resources/images/blue-border.png: Added.
• fast/html/resources/images/blue.png: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/html/object-border-expected.txt (added)
• LayoutTests/fast/html/object-border.html (added)
• LayoutTests/fast/html/resources/images/blue-border.png (added)
• LayoutTests/fast/html/resources/images/blue.png (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLObjectElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>
+
+        Reviewed by Darin Adler.
+
+        HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
+        https://bugs.webkit.org/show_bug.cgi?id=48596
+
+        * fast/html/object-border-expected.txt: Added.
+        * fast/html/object-border.html: Added.
+        * fast/html/resources/images/blue-border.png: Added.
+        * fast/html/resources/images/blue.png: Added.
+
 2010-12-20  Abhishek Arya  <inferno@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>
+
+        Reviewed by Darin Adler.
+
+        HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
+        https://bugs.webkit.org/show_bug.cgi?id=48596
+        
+        border attribute was not parsed in HTMLObjectElement.
+        I added code for it as HTMLImageElement handled.
+
+        new test:fast/html/object-border.html
+
+        * html/HTMLObjectElement.cpp:
+        (WebCore::HTMLObjectElement::parseMappedAttribute):
+
 2011-01-03  Darin Adler  <darin@apple.com>
 

trunk/WebCore/html/HTMLObjectElement.cpp

@@ -26 +26 @@
 
 #include "Attribute.h"
+#include "CSSValueKeywords.h"
 #include "EventNames.h"
 #include "ExceptionCode.h"
@@ -114 +115 @@
         }
         m_name = newName;
+    } else if (attr->name() == borderAttr) {
+        addCSSLength(attr, CSSPropertyBorderWidth, attr->value().toInt() ? attr->value() : "0");
+        addCSSProperty(attr, CSSPropertyBorderTopStyle, CSSValueSolid);
+        addCSSProperty(attr, CSSPropertyBorderRightStyle, CSSValueSolid);
+        addCSSProperty(attr, CSSPropertyBorderBottomStyle, CSSValueSolid);
+        addCSSProperty(attr, CSSPropertyBorderLeftStyle, CSSValueSolid);
     } else if (isIdAttributeName(attr->name())) {
         const AtomicString& newId = attr->value();