Changeset 75119 in webkit

Timestamp:

Jan 5, 2011 4:41:48 PM (13 years ago)

Author:

Girish Ramakrishnan

Message:

[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView

QML WebView creates QGraphicsWebView as it's child. The WebView is not
setup as a focus proxy of the QGraphicsWebView. Thus, even though the
WebView gets focus, the QGraphicsWebView does not get focus.
In QML, focus proxies or "focus scopes" are created using FocusScope.
This change makes WebView a FocusScope and sets the focus on the
QGraphicsWebView.

Reviewed by Simon Hausmann.
Acked by Aaron Kennedy <​aaron.kennedy@nokia.com>

​https://bugs.webkit.org/show_bug.cgi?id=51094

• declarative/qdeclarativewebview.cpp:

(QDeclarativeWebView::init):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• declarative/qdeclarativewebview.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2011-01-04  Girish Ramakrishnan  <girish@forwardbias.in>
+
+        Reviewed by Simon Hausmann.
+        Acked by Aaron Kennedy <aaron.kennedy@nokia.com>
+
+        [Qt] QML WebView does not transfer focus to underlying QGraphicsWebView
+
+        QML WebView creates QGraphicsWebView as it's child. The WebView is not
+        setup as a focus proxy of the QGraphicsWebView. Thus, even though the
+        WebView gets focus, the QGraphicsWebView does not get focus.
+        In QML, focus proxies or "focus scopes" are created using FocusScope.
+        This change makes WebView a FocusScope and sets the focus on the
+        QGraphicsWebView. 
+
+        https://bugs.webkit.org/show_bug.cgi?id=51094
+
+        * declarative/qdeclarativewebview.cpp:
+        (QDeclarativeWebView::init):
+
 2011-01-05  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/WebKit/qt/declarative/qdeclarativewebview.cpp

@@ -254 +254 @@
     setAcceptedMouseButtons(Qt::LeftButton);
     setFlag(QGraphicsItem::ItemHasNoContents, true);
+    setFlag(QGraphicsItem::ItemIsFocusScope, true);
     setClip(true);
 
     d->view = new GraphicsWebView(this);
     d->view->setResizesToContents(true);
+    d->view->setFocus();
     QWebPage* wp = new QDeclarativeWebPage(this);
     setPage(wp);