Changeset 75398 in webkit


Ignore:
Timestamp:
Jan 10, 2011 11:31:52 AM (13 years ago)
Author:
tony@chromium.org
Message:

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

Remove incorrect baselines.

  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

  • DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect

to trigger gif animations.

(WebViewHostPaintTask::WebViewHostPaintTask):
(WebViewHostPaintTask::runIfValid):
(WebViewHost::updatePaintRect):

  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::taskList):
Location:
trunk
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r75393 r75398  
     12011-01-10  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Mihai Parparita.
     4
     5        [chromium] fix for animated gif layout tests
     6        https://bugs.webkit.org/show_bug.cgi?id=52008
     7
     8        Remove incorrect baselines.
     9
     10        * platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Removed.
     11        * platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Removed.
     12        * platform/chromium/test_expectations.txt:
     13
    1142011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
    215
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r75393 r75398  
    28522852///////////////////////////////////////////////////////////////////////////
    28532853
    2854 // DRT needs to schedule paints on invalidations like Chrome does.
    2855 BUGCR62433 MAC LINUX : fast/backgrounds/animated-gif-as-background.html = IMAGE
    2856 BUGCR62433 MAC LINUX : fast/images/gif-loop-count.html = IMAGE
     2854// These need to be rebaselined on Windows.
     2855BUGCR62433 WIN : fast/backgrounds/animated-gif-as-background.html = IMAGE
     2856BUGCR62433 WIN : fast/images/gif-loop-count.html = IMAGE
    28572857
    28582858// input-speech related failures
  • trunk/Tools/ChangeLog

    r75397 r75398  
     12011-01-10  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Mihai Parparita.
     4
     5        [chromium] fix for animated gif layout tests
     6        https://bugs.webkit.org/show_bug.cgi?id=52008
     7
     8        * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
     9            to trigger gif animations.
     10        (WebViewHostPaintTask::WebViewHostPaintTask):
     11        (WebViewHostPaintTask::runIfValid):
     12        (WebViewHost::updatePaintRect):
     13        * DumpRenderTree/chromium/WebViewHost.h:
     14        (WebViewHost::taskList):
     15
    1162011-01-10  Alejandro G. Castro  <alex@igalia.com>
    217
  • trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp

    r75367 r75398  
    657657}
    658658
    659 
    660 
    661659void WebViewHost::closeWidget()
    662660{
     
    14081406// Painting functions ---------------------------------------------------------
    14091407
     1408class WebViewHostPaintTask : public MethodTask<WebViewHost> {
     1409public:
     1410    WebViewHostPaintTask(WebViewHost* object)
     1411        : MethodTask<WebViewHost>(object) {}
     1412    virtual void runIfValid() { m_object->paintInvalidatedRegion(); }
     1413};
     1414
    14101415void WebViewHost::updatePaintRect(const WebRect& rect)
    14111416{
     
    14221427    int bottom = max(m_paintRect.y + m_paintRect.height, rect.y + rect.height);
    14231428    m_paintRect = WebRect(left, top, right - left, bottom - top);
     1429
     1430    postDelayedTask(new WebViewHostPaintTask(this), 0);
    14241431}
    14251432
  • trunk/Tools/DumpRenderTree/chromium/WebViewHost.h

    r75367 r75398  
    3333
    3434#include "MockSpellCheck.h"
     35#include "Task.h"
    3536#include "TestNavigationController.h"
    3637#include "WebAccessibilityNotification.h"
     
    100101
    101102    WebKit::WebSpeechInputControllerMock* speechInputControllerMock() { return m_speechInputControllerMock.get(); }
     103
     104    // Needed by the MethodTask template.
     105    TaskList* taskList() { return &m_taskList; }
    102106
    103107    // NavigationHost
     
    309313    bool m_isPainting;
    310314
     315    TaskList m_taskList;
     316
    311317    OwnPtr<WebKit::WebContextMenuData> m_lastContextMenuData;
    312318
Note: See TracChangeset for help on using the changeset viewer.