Changeset 75401 in webkit

Timestamp:

Jan 10, 2011 12:00:42 PM (13 years ago)

Author:

mjs@apple.com

Message:

2011-01-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
​https://bugs.webkit.org/show_bug.cgi?id=52160

• WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout. Anything that can make runUntil() conditions turn true will happen on a run loop cycle anyway.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/mac/TestControllerMac.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-01-10  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
+        https://bugs.webkit.org/show_bug.cgi?id=52160
+
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
+        Anything that can make runUntil() conditions turn true will happen on a run loop cycle
+        anyway.
+
 2011-01-10  Tony Chang  <tony@chromium.org>
 

trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm

@@ -53 +53 @@
 {
     CFAbsoluteTime end = CFAbsoluteTimeGetCurrent() + timeout;
+    CFDateRef endDate = CFDateCreate(0, end);
     while (!done && CFAbsoluteTimeGetCurrent() < end)
-        [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]];
+        [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:(NSDate *)endDate];
+    CFRelease(endDate);
 }