Changeset 75439 in webkit

Timestamp:

Jan 10, 2011 2:47:22 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-01-10 Leonid Ebril <​leonid.ebril@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

​https://bugs.webkit.org/show_bug.cgi?id=51879

Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite
plugin if Flash 10 or newer (for Symbian platform), setting a nulled
window handler on destroy crashes WebKit.

• plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::determineQuirks):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/symbian/PluginPackageSymbian.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-10  Leonid Ebril  <leonid.ebril@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51879
+
+        Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite  
+        plugin if Flash 10 or newer (for Symbian platform), setting a nulled 
+        window handler on destroy crashes WebKit.
+
+        * plugins/symbian/PluginPackageSymbian.cpp:
+        (WebCore::PluginPackage::fetchInfo):
+        (WebCore::PluginPackage::determineQuirks):
+
 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp

@@ -56 +56 @@
             
             m_mimeToExtensions.add(mime[0], exts); // <MIME>,<ext1,ext2,ext3>
+            determineQuirks(mime[0]);
             if (mime.size() > 2)
                 m_mimeToDescriptions.add(mime[0], mime[2]); // <MIME>,<Description>
@@ -62 +63 @@
     unload();
     return true;
+}
+
+void PluginPackage::determineQuirks(const String& mimeType)
+{
+    if (mimeType == "application/x-shockwave-flash") {
+        PlatformModuleVersion flashTenVersion(0x000a0000);
+        if (compareFileVersion(flashTenVersion) >= 0) {
+            // Flash 10 doesn't like having a 0 window handle.
+            m_quirks.add(PluginQuirkDontSetNullWindowHandleOnDestroy);
+        }
+    }
 }