Changeset 75560 in webkit


Ignore:
Timestamp:
Jan 11, 2011 3:19:29 PM (13 years ago)
Author:
simonjam@chromium.org
Message:

2011-01-11 James Simonsen <​simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
​https://bugs.webkit.org/show_bug.cgi?id=52239

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/resources/webtiming-no-origin.html:
  • http/tests/misc/resources/webtiming-ssl.html:
  • http/tests/misc/webtiming-origins-expected.txt:
  • http/tests/misc/webtiming-ssl-expected.txt:

2011-01-11 James Simonsen <​simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
​https://bugs.webkit.org/show_bug.cgi?id=52239

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::secureConnectionStart):
  • page/PerformanceTiming.h:
  • page/PerformanceTiming.idl:
Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r75555 r75560  
     12011-01-11  James Simonsen  <simonjam@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Web Timing] Rename sslHandshakeStart to secureConnectionStart
     6        https://bugs.webkit.org/show_bug.cgi?id=52239
     7
     8        * fast/dom/Window/window-properties-performance-expected.txt:
     9        * fast/dom/script-tests/webtiming.js:
     10        (checkTimingBeforeLoad):
     11        (checkTimingWhileDeferred):
     12        (checkWebTimingOnDOMContentLoaded):
     13        (checkWebTimingWhileAsync):
     14        (checkWebTimingOnLoad):
     15        (checkWebTimingAfterLoad):
     16        * fast/dom/webtiming-document-open-expected.txt:
     17        * fast/dom/webtiming-expected.txt:
     18        * fast/dom/webtiming-navigate-within-document-expected.txt:
     19        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
     20        * http/tests/misc/resources/webtiming-cross-origin-redirect.html:
     21        * http/tests/misc/resources/webtiming-no-origin.html:
     22        * http/tests/misc/resources/webtiming-ssl.html:
     23        * http/tests/misc/webtiming-origins-expected.txt:
     24        * http/tests/misc/webtiming-ssl-expected.txt:
     25
    1262011-01-11  Mihai Parparita  <mihaip@chromium.org>
    227

  • trunk/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt

    r75200 r75560  
    3131window.performance.timing.responseEnd [number]
    3232window.performance.timing.responseStart [number]
    33 window.performance.timing.sslHandshakeStart [number]
     33window.performance.timing.secureConnectionStart [number]
    3434window.performance.timing.unloadEventEnd [number]
    3535window.performance.timing.unloadEventStart [number]

  • trunk/LayoutTests/fast/dom/script-tests/webtiming.js

    r75200 r75560  
    3232    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    3333
    34     shouldBe("timing.sslHandshakeStart", "0");
     34    shouldBe("timing.secureConnectionStart", "0");
    3535
    3636    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");
    … …  
    6464    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    6565
    66     shouldBe("timing.sslHandshakeStart", "0");
     66    shouldBe("timing.secureConnectionStart", "0");
    6767
    6868    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");
    … …  
    9797    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    9898
    99     shouldBe("timing.sslHandshakeStart", "0");
     99    shouldBe("timing.secureConnectionStart", "0");
    100100
    101101    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");
    … …  
    136136    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    137137
    138     shouldBe("timing.sslHandshakeStart", "0");
     138    shouldBe("timing.secureConnectionStart", "0");
    139139
    140140    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");
    … …  
    170170    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    171171
    172     shouldBe("timing.sslHandshakeStart", "0");
     172    shouldBe("timing.secureConnectionStart", "0");
    173173
    174174    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");
    … …  
    205205    shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.connectStart");
    206206
    207     shouldBe("timing.sslHandshakeStart", "0");
     207    shouldBe("timing.secureConnectionStart", "0");
    208208
    209209    shouldBeGreaterThanOrEqual("timing.requestStart", "timing.connectEnd");

  • trunk/LayoutTests/fast/dom/webtiming-document-open-expected.txt

    r74315 r75560  
    2222PASS timing.responseEnd is originalTiming.responseEnd
    2323PASS timing.responseStart is originalTiming.responseStart
    24 PASS timing.sslHandshakeStart is originalTiming.sslHandshakeStart
     24PASS timing.secureConnectionStart is originalTiming.secureConnectionStart
    2525PASS timing.unloadEventEnd is originalTiming.unloadEventEnd
    2626PASS timing.unloadEventStart is originalTiming.unloadEventStart

  • trunk/LayoutTests/fast/dom/webtiming-expected.txt

    r75129 r75560  
    1313PASS timing.connectStart is >= timing.domainLookupEnd
    1414PASS timing.connectEnd is >= timing.connectStart
    15 PASS timing.sslHandshakeStart is 0
     15PASS timing.secureConnectionStart is 0
    1616PASS timing.requestStart is >= timing.connectEnd
    1717PASS timing.responseStart is >= timing.requestStart
    … …  
    3232PASS timing.connectStart is >= timing.domainLookupEnd
    3333PASS timing.connectEnd is >= timing.connectStart
    34 PASS timing.sslHandshakeStart is 0
     34PASS timing.secureConnectionStart is 0
    3535PASS timing.requestStart is >= timing.connectEnd
    3636PASS timing.responseStart is >= timing.requestStart
    … …  
    5151PASS timing.connectStart is >= timing.domainLookupEnd
    5252PASS timing.connectEnd is >= timing.connectStart
    53 PASS timing.sslHandshakeStart is 0
     53PASS timing.secureConnectionStart is 0
    5454PASS timing.requestStart is >= timing.connectEnd
    5555PASS timing.responseStart is >= timing.requestStart
    … …  
    7070PASS timing.connectStart is >= timing.domainLookupEnd
    7171PASS timing.connectEnd is >= timing.connectStart
    72 PASS timing.sslHandshakeStart is 0
     72PASS timing.secureConnectionStart is 0
    7373PASS timing.requestStart is >= timing.connectEnd
    7474PASS timing.responseStart is >= timing.requestStart
    … …  
    8989PASS timing.connectStart is >= timing.domainLookupEnd
    9090PASS timing.connectEnd is >= timing.connectStart
    91 PASS timing.sslHandshakeStart is 0
     91PASS timing.secureConnectionStart is 0
    9292PASS timing.requestStart is >= timing.connectEnd
    9393PASS timing.responseStart is >= timing.requestStart
    … …  
    109109PASS timing.connectStart is >= timing.domainLookupEnd
    110110PASS timing.connectEnd is >= timing.connectStart
    111 PASS timing.sslHandshakeStart is 0
     111PASS timing.secureConnectionStart is 0
    112112PASS timing.requestStart is >= timing.connectEnd
    113113PASS timing.responseStart is >= timing.requestStart

  • trunk/LayoutTests/fast/dom/webtiming-navigate-within-document-expected.txt

    r74315 r75560  
    2222PASS responseEnd is unchanged.
    2323PASS responseStart is unchanged.
    24 PASS sslHandshakeStart is unchanged.
     24PASS secureConnectionStart is unchanged.
    2525PASS unloadEventEnd is unchanged.
    2626PASS unloadEventStart is unchanged.

  • trunk/LayoutTests/http/tests/misc/resources/webtiming-cross-origin-and-back2.html

    r75200 r75560  
    1717function performTest() {
    1818    // FIXME: Need a way to synchronize the test so that loadEventEnd is non-zero.
    19     var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "sslHandshakeStart"];
     19    var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "secureConnectionStart"];
    2020
    2121    var timingProperties = new Array;

  • trunk/LayoutTests/http/tests/misc/resources/webtiming-cross-origin-redirect.html

    r75200 r75560  
    1717function performTest() {
    1818    // FIXME: Need a way to synchronize the test so that loadEventEnd is non-zero.
    19     var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "sslHandshakeStart", "unloadEventStart", "unloadEventEnd"];
     19    var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventStart", "unloadEventEnd"];
    2020
    2121    var timingProperties = new Array;

  • trunk/LayoutTests/http/tests/misc/resources/webtiming-no-origin.html

    r75200 r75560  
    1717function performTest() {
    1818    // FIXME: Need a way to synchronize the test so that loadEventEnd is non-zero.
    19     var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "sslHandshakeStart", "unloadEventStart", "unloadEventEnd"];
     19    var shouldBeZeroList = ["loadEventEnd", "redirectStart", "redirectEnd", "secureConnectionStart", "unloadEventStart", "unloadEventEnd"];
    2020
    2121    var timingProperties = new Array;

  • trunk/LayoutTests/http/tests/misc/resources/webtiming-ssl.html

    r75200 r75560  
    1111<div id="console"></div>
    1212<script>
    13 description("This test checks that Web Timing reports sslHandshakeStart correctly and has reasonable values for connectStart and connectEnd. Note that DumpRenderTree doesn't set sslHandshakeStart.");
     13description("This test checks that Web Timing reports secureConnectionStart correctly and has reasonable values for connectStart and connectEnd. Note that DumpRenderTree doesn't set secureConnectionStart.");
    1414
    1515var performance = window.performance || {};
    … …  
    1818
    1919shouldBeGreaterThanOrEqual("timing.connectStart", "timing.navigationStart");
    20 shouldBeGreaterThanOrEqual("timing.sslHandshakeStart", "timing.connectStart");
    21 shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.sslHandshakeStart");
     20shouldBeGreaterThanOrEqual("timing.secureConnectionStart", "timing.connectStart");
     21shouldBeGreaterThanOrEqual("timing.connectEnd", "timing.secureConnectionStart");
    2222
    2323var successfullyParsed = true;

  • trunk/LayoutTests/http/tests/misc/webtiming-origins-expected.txt

    r75129 r75560  
    2727PASS timing.responseEnd is non-zero.
    2828PASS timing.responseStart is non-zero.
    29 PASS timing.sslHandshakeStart is 0
     29PASS timing.secureConnectionStart is 0
    3030PASS timing.unloadEventEnd is 0
    3131PASS timing.unloadEventStart is 0
    … …  
    6262PASS timing.responseEnd is non-zero.
    6363PASS timing.responseStart is non-zero.
    64 PASS timing.sslHandshakeStart is 0
     64PASS timing.secureConnectionStart is 0
    6565PASS timing.unloadEventEnd is 0
    6666PASS timing.unloadEventStart is 0
    … …  
    9797PASS timing.responseEnd is non-zero.
    9898PASS timing.responseStart is non-zero.
    99 PASS timing.sslHandshakeStart is 0
     99PASS timing.secureConnectionStart is 0
    100100PASS timing.unloadEventEnd is non-zero.
    101101PASS timing.unloadEventStart is non-zero.

  • trunk/LayoutTests/http/tests/misc/webtiming-ssl-expected.txt

    r74361 r75560  
    1 This test checks that Web Timing reports sslHandshakeStart correctly and has reasonable values for connectStart and connectEnd. Note that DumpRenderTree doesn't set sslHandshakeStart.
     1This test checks that Web Timing reports secureConnectionStart correctly and has reasonable values for connectStart and connectEnd. Note that DumpRenderTree doesn't set secureConnectionStart.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    … …  
    55
    66PASS timing.connectStart is >= timing.navigationStart
    7 FAIL timing.sslHandshakeStart should be >= timing.connectStart. Was 0 (of type number).
    8 PASS timing.connectEnd is >= timing.sslHandshakeStart
     7FAIL timing.secureConnectionStart should be >= timing.connectStart. Was 0 (of type number).
     8PASS timing.connectEnd is >= timing.secureConnectionStart
    99PASS successfullyParsed is true
    1010

  • trunk/Source/WebCore/ChangeLog

    r75557 r75560  
     12011-01-11  James Simonsen  <simonjam@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Web Timing] Rename sslHandshakeStart to secureConnectionStart
     6        https://bugs.webkit.org/show_bug.cgi?id=52239
     7
     8        * page/PerformanceTiming.cpp:
     9        (WebCore::PerformanceTiming::secureConnectionStart):
     10        * page/PerformanceTiming.h:
     11        * page/PerformanceTiming.idl:
     12
    1132011-01-11  Adam Barth  <abarth@webkit.org>
    214

  • trunk/Source/WebCore/page/PerformanceTiming.cpp

    r75129 r75560  
    228228}
    229229
    230 unsigned long long PerformanceTiming::sslHandshakeStart() const
     230unsigned long long PerformanceTiming::secureConnectionStart() const
    231231{
    232232    DocumentLoader* loader = documentLoader();

  • trunk/Source/WebCore/page/PerformanceTiming.h

    r74315 r75560  
    6262    unsigned long long connectStart() const;
    6363    unsigned long long connectEnd() const;
    64     unsigned long long sslHandshakeStart() const;
     64    unsigned long long secureConnectionStart() const;
    6565    unsigned long long requestStart() const;
    6666    unsigned long long responseStart() const;

  • trunk/Source/WebCore/page/PerformanceTiming.idl

    r74315 r75560  
    4343        readonly attribute unsigned long long connectStart;
    4444        readonly attribute unsigned long long connectEnd;
    45         readonly attribute unsigned long long sslHandshakeStart;
     45        readonly attribute unsigned long long secureConnectionStart;
    4646        readonly attribute unsigned long long requestStart;
    4747        readonly attribute unsigned long long responseStart;
Note: See TracChangeset for help on using the changeset viewer.