Changeset 76002 in webkit


Ignore:
Timestamp:
Jan 18, 2011 12:00:50 AM (13 years ago)
Author:
rwlbuis@webkit.org
Message:

2011-01-17 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
​https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Tests: fast/forms/select-option-background-color-change.html

fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):
Location:
trunk
Files:
12 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r75996 r76002  
     12011-01-17  Rob Buis  <rwlbuis@gmail.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Add tests for:
     6        Color changes to option elements in a select multiple aren't drawn immediately
     7        https://bugs.webkit.org/show_bug.cgi?id=49790
     8
     9        * fast/forms/select-option-background-color-change.html: Added.
     10        * fast/forms/select-option-color-change.html: Added.
     11        * fast/forms/select-option-visibility-change.html: Added.
     12        * platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Added.
     13        * platform/mac/fast/forms/select-option-background-color-change-expected.png: Added.
     14        * platform/mac/fast/forms/select-option-background-color-change-expected.txt: Added.
     15        * platform/mac/fast/forms/select-option-color-change-expected.checksum: Added.
     16        * platform/mac/fast/forms/select-option-color-change-expected.png: Added.
     17        * platform/mac/fast/forms/select-option-color-change-expected.txt: Added.
     18        * platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Added.
     19        * platform/mac/fast/forms/select-option-visibility-change-expected.png: Added.
     20        * platform/mac/fast/forms/select-option-visibility-change-expected.txt: Added.
     21
    1222011-01-17  Steve Lacey  <sjl@chromium.org>
    223

  • trunk/Source/WebCore/ChangeLog

    r76001 r76002  
     12011-01-17  Rob Buis  <rwlbuis@gmail.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Color changes to option elements in a select multiple aren't drawn immediately
     6        https://bugs.webkit.org/show_bug.cgi?id=49790
     7
     8        Redirect style changes on <option> element to the owner <select> element.
     9
     10        Tests: fast/forms/select-option-background-color-change.html
     11               fast/forms/select-option-color-change.html
     12               fast/forms/select-option-visibility-change.html
     13
     14        * html/HTMLOptionElement.cpp:
     15        (WebCore::HTMLOptionElement::setRenderStyle):
     16
    1172011-01-17  MORITA Hajime  <morrita@google.com>
    218

  • trunk/Source/WebCore/html/HTMLOptionElement.cpp

    r73589 r76002  
    222222{
    223223    m_style = newStyle;
     224    if (HTMLSelectElement* select = ownerSelectElement())
     225        if (RenderObject* renderer = select->renderer())
     226            renderer->repaint();
    224227}
    225228
Note: See TracChangeset for help on using the changeset viewer.