Changeset 76101 in webkit


Ignore:
Timestamp:
Jan 18, 2011 9:15:10 PM (13 years ago)
Author:
dpranke@chromium.org
Message:

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --build-directory command line argument

Official Google Chrome builds use a non-standard build directory
location. This patch adds a --build-directory argument that
allows that location to be specified on the command line. Only
Chromium-based builds will use this flag for now, but anyone can
in the future.

There are no unit tests for this since it's difficult to test
until mock filesystems are fully supported in the code. This was
tested by hand for now.

https://bugs.webkit.org/show_bug.cgi?id=52694

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r76096 r76101  
     12011-01-18  Dirk Pranke  <dpranke@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        new-run-webkit-tests: add a --build-directory command line argument
     6
     7        Official Google Chrome builds use a non-standard build directory
     8        location. This patch adds a --build-directory argument that
     9        allows that location to be specified on the command line. Only
     10        Chromium-based builds will use this flag for now, but anyone can
     11        in the future.
     12
     13        There are no unit tests for this since it's difficult to test
     14        until mock filesystems are fully supported in the code. This was
     15        tested by hand for now.
     16
     17        https://bugs.webkit.org/show_bug.cgi?id=52694
     18
     19        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
     20        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
     21        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
     22        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
     23
    1242011-01-18  Maciej Stachowiak  <mjs@apple.com>
    225
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py

    r73748 r76101  
    7979
    8080    def _build_path(self, *comps):
     81        if self.get_option('build_directory'):
     82            return self._filesystem.join(self.get_option('build_directory'),
     83                                         *comps)
     84
    8185        base = self.path_from_chromium_base()
    8286        if os.path.exists(os.path.join(base, 'sconsbuild')):
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py

    r76081 r76101  
    106106
    107107    def _build_path(self, *comps):
     108        if self.get_option('build_directory'):
     109            return self._filesystem.join(self.get_option('build_directory'),
     110                                         *comps)
     111
    108112        path = self.path_from_chromium_base('xcodebuild', *comps)
    109113        if os.path.exists(path) or self.get_option('use_test_shell'):
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

    r73748 r76101  
    107107    #
    108108    def _build_path(self, *comps):
     109        if self.get_option('build_directory'):
     110            return self._filesystem.join(self.get_option('build_directory'),
     111                                         *comps)
     112
    109113        p = self.path_from_chromium_base('webkit', *comps)
    110114        if os.path.exists(p):
  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

    r75800 r76101  
    278278            help="Output results directory source dir, relative to Debug or "
    279279                 "Release"),
     280        optparse.make_option("--build-directory",
     281            help="Path to the directory under which build files are kept (should not include configuration)"),
    280282        optparse.make_option("--new-baseline", action="store_true",
    281283            default=False, help="Save all generated results as new baselines "
Note: See TracChangeset for help on using the changeset viewer.