Changeset 76271 in webkit

Timestamp:

Jan 20, 2011 12:32:22 PM (13 years ago)

Author:

ojan@chromium.org

Message:

2011-01-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix goofup in ​http://trac.webkit.org/changeset/76082
​https://bugs.webkit.org/show_bug.cgi?id=52830

We were showing the revision number of the patch at the bottom
of the diff and expanding from the bottom of the diff would fail.

Also, removed an unused variable and scoped queries appropriatly
to the file_diff they should have been operating on.

• PrettyPatch/PrettyPatch.rb:
• code-review.js:

Location:

trunk/Websites/bugs.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• PrettyPatch/PrettyPatch.rb (modified) (2 diffs)
• code-review.js (modified) (2 diffs)

trunk/Websites/bugs.webkit.org/ChangeLog

@@ +1 @@
+2011-01-20  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        fix goofup in http://trac.webkit.org/changeset/76082
+        https://bugs.webkit.org/show_bug.cgi?id=52830
+
+        We were showing the revision number of the patch at the bottom
+        of the diff and expanding from the bottom of the diff would fail.
+
+        Also, removed an unused variable and scoped queries appropriatly
+        to the file_diff they should have been operating on.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2011-01-19  Ojan Vafai  <ojan@chromium.org>
 

trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb

@@ -409 +409 @@
 }
 
+.revision {
+  display: none;
+}
+
 .clear_float {
     clear: both;
@@ -414 +418 @@
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=25"></script>
+<script src="code-review.js?version=26"></script>
 EOF
 

trunk/Websites/bugs.webkit.org/code-review.js

@@ -370 +370 @@
     var expand_bar_index = 0;
     if (!$(first_line).hasClass('add') && !$(first_line).hasClass('remove'))
-      $('h1', file_diff).after(expandBarHtml(file_name, BELOW))
-
-    $('br').replaceWith(expandBarHtml(file_name));
+      $('h1', file_diff).after(expandBarHtml(BELOW))
+
+    $('br', file_diff).replaceWith(expandBarHtml());
 
     var last_line = file_diff.querySelector('.LineContainer:last-of-type');
@@ -378 +378 @@
     // with a from line number of 0. Don't show expand links in that case either.
     if (!$(last_line).hasClass('add') && !$(last_line).hasClass('remove') && fromLineNumber(last_line) != 0)
-      $(file_diff).append(expandBarHtml(file_name, ABOVE));
-  }
-
-  function expandBarHtml(file_name, opt_direction) {
+      $('.revision', file_diff).before(expandBarHtml(ABOVE));
+  }
+
+  function expandBarHtml(opt_direction) {
     var html = '<div class="ExpandBar">' +
         '<div class="ExpandArea Expand' + ABOVE + '"></div>' +