Changeset 76276 in webkit


Ignore:
Timestamp:
Jan 20, 2011 1:34:34 PM (13 years ago)
Author:
jamesr@google.com
Message:

2011-01-20 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
​https://bugs.webkit.org/show_bug.cgi?id=52770

Tests ::-webkit-scrollbar-corner inside a table.

  • fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
  • fast/css-generated-content/table-with-scrollbar-corner.html: Added.

2011-01-20 James Robinson <​jamesr@chromium.org>

Reviewed by Eric "Baller" Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
​https://bugs.webkit.org/show_bug.cgi?id=52770

Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.

Test: fast/css-generated-content/table-with-scrollbar-corner.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setNeedsCellRecalc):
  • rendering/RenderTableSection.h:
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r76275 r76276  
     12011-01-20  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        RenderTableSection's setNeedsCellRecalc needs to null check table()
     6        https://bugs.webkit.org/show_bug.cgi?id=52770
     7
     8        Tests ::-webkit-scrollbar-corner inside a table.
     9
     10        * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
     11        * fast/css-generated-content/table-with-scrollbar-corner.html: Added.
     12
    1132011-01-20  Michael Saboff  <msaboff@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r76274 r76276  
     12011-01-20  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Eric "Baller" Seidel.
     4
     5        RenderTableSection's setNeedsCellRecalc needs to null check table()
     6        https://bugs.webkit.org/show_bug.cgi?id=52770
     7
     8        Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
     9        This can be null during detach().  Test constructed by Eric Seidel.
     10
     11        Test: fast/css-generated-content/table-with-scrollbar-corner.html
     12
     13        * rendering/RenderTableSection.cpp:
     14        (WebCore::RenderTableSection::setNeedsCellRecalc):
     15        * rendering/RenderTableSection.h:
     16
    1172011-01-20  Dirk Schulze  <krit@webkit.org>
    218

  • trunk/Source/WebCore/rendering/RenderTableSection.cpp

    r75837 r76276  
    10841084}
    10851085
     1086void RenderTableSection::setNeedsCellRecalc()
     1087{
     1088    m_needsCellRecalc = true;
     1089    if (RenderTable* t = table())
     1090        t->setNeedsSectionRecalc();
     1091}
     1092
    10861093void RenderTableSection::clearGrid()
    10871094{

  • trunk/Source/WebCore/rendering/RenderTableSection.h

    r73385 r76276  
    115115
    116116    bool needsCellRecalc() const { return m_needsCellRecalc; }
    117     void setNeedsCellRecalc()
    118     {
    119         m_needsCellRecalc = true;
    120         table()->setNeedsSectionRecalc();
    121     }
     117    void setNeedsCellRecalc();
    122118
    123119    int getBaseline(int row) { return m_grid[row].baseline; }
Note: See TracChangeset for help on using the changeset viewer.