Changeset 76303 in webkit


Ignore:
Timestamp:
Jan 20, 2011 4:05:35 PM (13 years ago)
Author:
Nate Chapin
Message:

2011-01-20 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=52769.

  • fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
  • fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
  • fast/dom/Window/Location/set-location-after-close.html: Added.

2011-01-20 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Null-check m_frame in DOMWindow::setLocation(), since it's
possible to reach this point without it having been checked
already.
https://bugs.webkit.org/show_bug.cgi?id=52769

Test: fast/dom/Window/Location/set-location-after-close.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation):
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r76301 r76303  
     12011-01-20  Nate Chapin  <japhet@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Test for https://bugs.webkit.org/show_bug.cgi?id=52769.
     6
     7        * fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
     8        * fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
     9        * fast/dom/Window/Location/set-location-after-close.html: Added.
     10
    1112011-01-20  Chang Shu  <chang.shu@nokia.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r76301 r76303  
     12011-01-20  Nate Chapin  <japhet@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Null-check m_frame in DOMWindow::setLocation(), since it's
     6        possible to reach this point without it having been checked
     7        already.
     8        https://bugs.webkit.org/show_bug.cgi?id=52769
     9
     10        Test: fast/dom/Window/Location/set-location-after-close.html
     11
     12        * page/DOMWindow.cpp:
     13        (WebCore::DOMWindow::setLocation):
     14
    1152011-01-20  Chang Shu  <chang.shu@nokia.com>
    216
  • trunk/Source/WebCore/page/DOMWindow.cpp

    r76278 r76303  
    16181618void DOMWindow::setLocation(const String& urlString, DOMWindow* activeWindow, DOMWindow* firstWindow, SetLocationLocking locking)
    16191619{
     1620    if (!m_frame)
     1621        return;
     1622
    16201623    Frame* activeFrame = activeWindow->frame();
    16211624    if (!activeFrame)
Note: See TracChangeset for help on using the changeset viewer.