Changeset 76311 in webkit


Ignore:
Timestamp:
Jan 20, 2011 5:06:47 PM (13 years ago)
Author:
dpranke@chromium.org
Message:

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Fix bug introduced in r72688 / bug 52768 that broke the
generation of the output filename links in the results.html
output. Apparently none of the unit tests actually checked to
make sure the generated links were correct :(

https://bugs.webkit.org/show_bug.cgi?id=52854

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r76306 r76311  
     12011-01-20  Dirk Pranke  <dpranke@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        Fix bug introduced in r72688 / bug 52768 that broke the
     6        generation of the output filename links in the results.html
     7        output. Apparently none of the unit tests actually checked to
     8        make sure the generated links were correct :(
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=52854
     11
     12        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
     13        * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
     14
    1152011-01-20  Alexey Proskuryakov  <ap@apple.com>
    216
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py

    r76288 r76311  
    124124        # the extension, but passing in a Filesystem object here is a huge
    125125        # hassle.
    126         return filename[filename.rfind('.')] + modifier
     126        return filename[:filename.rfind('.')] + modifier
    127127
    128128
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py

    r75191 r76311  
    9090        self.assertEqual(len(crash_set), 2)
    9191
     92    def test_relative_output_filename(self):
     93        # This could be any Failure* object, since we're testing a method
     94        # on the base class.
     95        failure_obj = FailureTextMismatch()
     96        actual_filename = failure_obj.relative_output_filename("fast/html/article-element.html", "-actual.txt")
     97        self.assertEquals(actual_filename, "fast/html/article-element-actual.txt")
    9298
    9399if __name__ == '__main__':
Note: See TracChangeset for help on using the changeset viewer.