Changeset 76376 in webkit

Timestamp:

Jan 21, 2011 12:01:11 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-01-21 Peter Gal <​galpeter@inf.u-szeged.hu>

Reviewed by Darin Adler.

REGRESSION(r76177): All JavaScriptCore tests fail on ARM
​https://bugs.webkit.org/show_bug.cgi?id=52814

Get the approximateByteSize value before releasing the OwnPtr.

• parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/JSParser.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-01-21  Peter Gal  <galpeter@inf.u-szeged.hu>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION(r76177): All JavaScriptCore tests fail on ARM
+        https://bugs.webkit.org/show_bug.cgi?id=52814
+
+        Get the approximateByteSize value before releasing the OwnPtr.
+
+        * parser/JSParser.cpp:
+        (JSC::JSParser::parseFunctionInfo):
+
 2011-01-21  Xan Lopez  <xlopez@igalia.com>
 

trunk/Source/JavaScriptCore/parser/JSParser.cpp

@@ -1358 +1358 @@
     matchOrFail(CLOSEBRACE);
 
-    if (newInfo)
-        m_functionCache->add(openBracePos, newInfo.release(), newInfo->approximateByteSize());
+    if (newInfo) {
+        unsigned approximateByteSize = newInfo->approximateByteSize();
+        m_functionCache->add(openBracePos, newInfo.release(), approximateByteSize);
+    }
 
     next();