Changeset 76390 in webkit


Ignore:
Timestamp:
Jan 21, 2011 1:43:03 PM (13 years ago)
Author:
crogers@google.com
Message:

2011-01-21 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
​https://bugs.webkit.org/show_bug.cgi?id=52741

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled):
  • src/WebSettingsImpl.h:

2011-01-21 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
​https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebPreferenceKeysPrivate.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-21 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
​https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2011-01-21 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
​https://bugs.webkit.org/show_bug.cgi?id=52741

No new tests since audio API is not yet implemented.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
  • page/DOMWindow.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled):
  • page/Settings.h: (WebCore::Settings::webAudioEnabled):
Location:
trunk/Source
Files:
21 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r76388 r76390  
     12011-01-21  Chris Rogers  <crogers@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Add run-time enable support for the web audio API
     6        https://bugs.webkit.org/show_bug.cgi?id=52741
     7
     8        No new tests since audio API is not yet implemented.
     9
     10        * WebCore.exp.in:
     11        * bindings/generic/RuntimeEnabledFeatures.cpp:
     12        * bindings/generic/RuntimeEnabledFeatures.h:
     13        (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled):
     14        (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
     15        * page/DOMWindow.idl:
     16        * page/Settings.cpp:
     17        (WebCore::Settings::Settings):
     18        (WebCore::Settings::setWebAudioEnabled):
     19        * page/Settings.h:
     20        (WebCore::Settings::webAudioEnabled):
     21
    1222011-01-21  Martin Robinson  <mrobinson@igalia.com>
    223

  • trunk/Source/WebCore/WebCore.exp.in

    r76357 r76390  
    782782__ZN7WebCore8PositionC1EN3WTF10PassRefPtrINS_4NodeEEEi
    783783__ZN7WebCore8Settings14setJavaEnabledEb
     784__ZN7WebCore8Settings18setWebAudioEnabledEb
    784785__ZN7WebCore8Settings15setWebGLEnabledEb
    785786__ZN7WebCore8Settings16setUsesPageCacheEb

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r68222 r76390  
    4949bool RuntimeEnabledFeatures::isGeolocationEnabled = true;
    5050bool RuntimeEnabledFeatures::isIndexedDBEnabled = false;
     51bool RuntimeEnabledFeatures::isWebAudioEnabled = false;
    5152bool RuntimeEnabledFeatures::isWebGLEnabled = false;
    5253bool RuntimeEnabledFeatures::isPushStateEnabled = false;

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r73669 r76390  
    9393#endif
    9494
     95#if ENABLE(WEB_AUDIO)
     96    static void setWebkitAudioContextEnabled(bool isEnabled) { isWebAudioEnabled = isEnabled; }
     97    static bool webkitAudioContextEnabled() { return isWebAudioEnabled; }
     98#endif
     99
    95100#if ENABLE(3D_CANVAS) || ENABLE(BLOB)
    96101    static void setWebGLEnabled(bool isEnabled) { isWebGLEnabled = isEnabled; }
    … …  
    175180    static bool isGeolocationEnabled;
    176181    static bool isIndexedDBEnabled;
     182    static bool isWebAudioEnabled;
    177183    static bool isWebGLEnabled;
    178184    static bool isPushStateEnabled;

  • trunk/Source/WebCore/page/DOMWindow.idl

    r76278 r76390  
    516516        attribute [JSCCustomGetter,Conditional=3D_CANVAS|BLOB,EnabledAtRuntime] DataViewConstructor DataView; // Usable with new operator
    517517
    518         attribute [JSCCustomGetter,Conditional=WEB_AUDIO] AudioContextConstructor webkitAudioContext; // Usable with new operator
     518        attribute [JSCCustomGetter,Conditional=WEB_AUDIO,EnabledAtRuntime] AudioContextConstructor webkitAudioContext; // Usable with new operator
    519519        attribute [Conditional=WEB_AUDIO] AudioPannerNodeConstructor webkitAudioPannerNode; // Needed for panning model constants
    520520

  • trunk/Source/WebCore/page/Settings.cpp

    r74041 r76390  
    157157    , m_experimentalNotificationsEnabled(false)
    158158    , m_webGLEnabled(false)
     159    , m_webAudioEnabled(false)
    159160    , m_acceleratedCanvas2dEnabled(false)
    160161    , m_loadDeferringEnabled(true)
    … …  
    656657#endif
    657658
     659void Settings::setWebAudioEnabled(bool enabled)
     660{
     661    m_webAudioEnabled = enabled;
     662}
     663
    658664void Settings::setWebGLEnabled(bool enabled)
    659665{

  • trunk/Source/WebCore/page/Settings.h

    r76248 r76390  
    312312        void setPluginAllowedRunTime(unsigned);
    313313        unsigned pluginAllowedRunTime() const { return m_pluginAllowedRunTime; }
     314
     315        void setWebAudioEnabled(bool);
     316        bool webAudioEnabled() const { return m_webAudioEnabled; }
    314317
    315318        void setWebGLEnabled(bool);
    … …  
    435438        bool m_experimentalNotificationsEnabled : 1;
    436439        bool m_webGLEnabled : 1;
     440        bool m_webAudioEnabled : 1;
    437441        bool m_acceleratedCanvas2dEnabled : 1;
    438442        bool m_loadDeferringEnabled : 1;

  • trunk/Source/WebKit/chromium/ChangeLog

    r76383 r76390  
     12011-01-21  Chris Rogers  <crogers@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Add run-time enable support for the web audio API
     6        https://bugs.webkit.org/show_bug.cgi?id=52741
     7
     8        * public/WebRuntimeFeatures.h:
     9        * public/WebSettings.h:
     10        * src/WebRuntimeFeatures.cpp:
     11        (WebKit::WebRuntimeFeatures::enableWebAudio):
     12        (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
     13        * src/WebSettingsImpl.cpp:
     14        (WebKit::WebSettingsImpl::setWebAudioEnabled):
     15        * src/WebSettingsImpl.h:
     16
    1172011-01-21  Ryosuke Niwa  <rniwa@webkit.org>
    218

  • trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h

    r66570 r76390  
    6969    WEBKIT_API static bool isIndexedDatabaseEnabled();
    7070
     71    WEBKIT_API static void enableWebAudio(bool);
     72    WEBKIT_API static bool isWebAudioEnabled();
     73
    7174    WEBKIT_API static void enableWebGL(bool);
    7275    WEBKIT_API static bool isWebGLEnabled();

  • trunk/Source/WebKit/chromium/public/WebSettings.h

    r75805 r76390  
    9090    virtual void setTextDirectionSubmenuInclusionBehaviorNeverIncluded() = 0;
    9191    virtual void setOfflineWebApplicationCacheEnabled(bool) = 0;
     92    virtual void setWebAudioEnabled(bool) = 0;
    9293    virtual void setExperimentalWebGLEnabled(bool) = 0;
    9394    virtual void setShowDebugBorders(bool) = 0;

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r69540 r76390  
    185185}
    186186
     187void WebRuntimeFeatures::enableWebAudio(bool enable)
     188{
     189#if ENABLE(WEB_AUDIO)
     190    RuntimeEnabledFeatures::setWebkitAudioContextEnabled(enable);
     191#endif
     192}
     193
     194bool WebRuntimeFeatures::isWebAudioEnabled()
     195{
     196#if ENABLE(WEB_AUDIO)
     197    return RuntimeEnabledFeatures::webkitAudioContextEnabled();
     198#else
     199    return false;
     200#endif
     201}
     202
    187203void WebRuntimeFeatures::enableWebGL(bool enable)
    188204{

  • trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp

    r75805 r76390  
    265265}
    266266
     267void WebSettingsImpl::setWebAudioEnabled(bool enabled)
     268{
     269    m_settings->setWebAudioEnabled(enabled);
     270}
     271
    267272void WebSettingsImpl::setExperimentalWebGLEnabled(bool enabled)
    268273{

  • trunk/Source/WebKit/chromium/src/WebSettingsImpl.h

    r75805 r76390  
    8585    virtual void setTextDirectionSubmenuInclusionBehaviorNeverIncluded();
    8686    virtual void setOfflineWebApplicationCacheEnabled(bool);
     87    virtual void setWebAudioEnabled(bool);
    8788    virtual void setExperimentalWebGLEnabled(bool);
    8889    virtual void setShowDebugBorders(bool);

  • trunk/Source/WebKit/mac/ChangeLog

    r76300 r76390  
     12011-01-21  Chris Rogers  <crogers@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Add run-time enable support for the web audio API
     6        https://bugs.webkit.org/show_bug.cgi?id=52741
     7
     8        * WebView/WebPreferenceKeysPrivate.h:
     9        * WebView/WebPreferences.mm:
     10        (-[WebPreferences webAudioEnabled]):
     11        (-[WebPreferences setWebAudioEnabled:]):
     12        * WebView/WebPreferencesPrivate.h:
     13        * WebView/WebView.mm:
     14        (-[WebView _preferencesChangedNotification:]):
     15
    1162011-01-20  John Sullivan  <sullivan@apple.com>
    217

  • trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h

    r73886 r76390  
    9292#define WebKitShowDebugBordersPreferenceKey @"WebKitShowDebugBorders"
    9393#define WebKitShowRepaintCounterPreferenceKey @"WebKitShowRepaintCounter"
     94#define WebKitWebAudioEnabledPreferenceKey @"WebKitWebAudioEnabled"
    9495#define WebKitWebGLEnabledPreferenceKey @"WebKitWebGLEnabled"
    9596#define WebKitAccelerated2dCanvasEnabledPreferenceKey @"WebKitAccelerated2dCanvasEnabled"

  • trunk/Source/WebKit/mac/WebView/WebPreferences.mm

    r74041 r76390  
    12651265}
    12661266
     1267- (BOOL)webAudioEnabled
     1268{
     1269    return [self _boolValueForKey:WebKitWebAudioEnabledPreferenceKey];
     1270}
     1271
     1272- (void)setWebAudioEnabled:(BOOL)enabled
     1273{
     1274    [self _setBoolValue:enabled forKey:WebKitWebAudioEnabledPreferenceKey];
     1275}
     1276
    12671277- (BOOL)webGLEnabled
    12681278{

  • trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h

    r73886 r76390  
    186186- (void)setShowRepaintCounter:(BOOL)show;
    187187
     188- (BOOL)webAudioEnabled;
     189- (void)setWebAudioEnabled:(BOOL)enabled;
     190
    188191- (BOOL)webGLEnabled;
    189192- (void)setWebGLEnabled:(BOOL)enabled;

  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r76196 r76390  
    14971497    settings->setShowRepaintCounter([preferences showRepaintCounter]);
    14981498    settings->setPluginAllowedRunTime([preferences pluginAllowedRunTime]);
     1499    settings->setWebAudioEnabled([preferences webAudioEnabled]);
    14991500    settings->setWebGLEnabled([preferences webGLEnabled]);
    15001501    settings->setAccelerated2dCanvasEnabled([preferences accelerated2dCanvasEnabled]);

  • trunk/Source/WebKit/win/ChangeLog

    r76389 r76390  
     12011-01-21  Chris Rogers  <crogers@google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Add run-time enable support for the web audio API
     6        https://bugs.webkit.org/show_bug.cgi?id=52741
     7
     8        * WebPreferenceKeysPrivate.h:
     9        * WebView.cpp:
     10        (WebView::notifyPreferencesChanged):
     11
    1122011-01-21  Sam Weinig  <sam@webkit.org>
    213

  • trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h

    r68166 r76390  
    6868#define WebKitLocalStorageDatabasePathPreferenceKey "WebKitLocalStorageDatabasePath"
    6969#define WebKitHyperlinkAuditingEnabledPreferenceKey "WebKitHyperlinkAuditingEnabled"
     70#define WebKitWebAudioEnabledPreferenceKey "WebKitWebAudioEnabled"
    7071
    7172// These are private both because callers should be using the cover methods and because the

  • trunk/Source/WebKit/win/WebView.cpp

    r76372 r76390  
    48034803    settings->setShowRepaintCounter(enabled);
    48044804
     4805#if ENABLE(WEB_AUDIO)
     4806    settings->setWebAudioEnabled(true);
     4807#endif // ENABLE(WEB_AUDIO)
     4808
    48054809#if ENABLE(3D_CANVAS)
    48064810    settings->setWebGLEnabled(true);
Note: See TracChangeset for help on using the changeset viewer.