Changeset 76395 in webkit

Timestamp:

Jan 21, 2011 2:32:15 PM (13 years ago)

Author:

tony@chromium.org

Message:

2011-01-21 Tony Chang <​tony@chromium.org>

Reviewed by Sam Weinig.

reduce number of FrameLoaderClient::didChangeScrollOffset calls
​https://bugs.webkit.org/show_bug.cgi?id=52915

Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.

Covered by Chromium browser_tests.

• platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollAnimator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-21  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Sam Weinig.
+
+        reduce number of FrameLoaderClient::didChangeScrollOffset calls
+        https://bugs.webkit.org/show_bug.cgi?id=52915
+
+        Only notify of changes in scroll offset when there actually is a change.
+        This regressed in r76291.
+
+        Covered by Chromium browser_tests.
+
+        * platform/ScrollAnimator.cpp:
+        (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
+
 2011-01-21  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/platform/ScrollAnimator.cpp

@@ -72 +72 @@
 void ScrollAnimator::scrollToOffsetWithoutAnimation(const FloatPoint& offset)
 {
-    m_currentPosX = offset.x();
-    m_currentPosY = offset.y();
-    notityPositionChanged();
+    if (m_currentPosX != offset.x() || m_currentPosY != offset.y()) {
+        m_currentPosX = offset.x();
+        m_currentPosY = offset.y();
+        notityPositionChanged();
+    }
 }