Changeset 76433 in webkit

Timestamp:

Jan 22, 2011 12:22:00 AM (13 years ago)

Author:

ap@apple.com

Message:

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

• page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually draw inside the requested rectangle.

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

• UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use a correct offset when flipping.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/PrintContext.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/mac/WKView.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-22  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        https://bugs.webkit.org/show_bug.cgi?id=52951
+        WebKit2 generates a bad PDF for cross process messaging
+
+        * page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually
+        draw inside the requested rectangle.
+
 2011-01-21  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/page/PrintContext.cpp

@@ -167 +167 @@
     ctx.save();
     ctx.scale(FloatSize(1, -1));
-    ctx.translate(0, -rect.height());
+    ctx.translate(0, -m_frame->view()->contentsHeight());
     ctx.clip(rect);
     m_frame->view()->paintContents(&ctx, rect);

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-01-22  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        https://bugs.webkit.org/show_bug.cgi?id=52951
+        WebKit2 generates a bad PDF for cross process messaging
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
+        Use a correct offset when flipping.
+
 2011-01-21  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -1498 +1498 @@
     // Flip the destination.
     CGContextScaleCTM(context, 1, -1);
-    CGContextTranslateCTM(context, 0, -rect.size.height);
+    CGContextTranslateCTM(context, 0, -CGPDFPageGetBoxRect(pdfPage, kCGPDFMediaBox).size.height);
     CGContextDrawPDFPage(context, pdfPage);
     CGContextRestoreGState(context);