Changeset 76555 in webkit

Timestamp:

Jan 24, 2011 4:47:18 PM (13 years ago)

Author:

Martin Robinson

Message:

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
​https://bugs.webkit.org/show_bug.cgi?id=52553

• platform/gtk/Skipped: Unskip tests which are no longer timing out.

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
​https://bugs.webkit.org/show_bug.cgi?id=52553

Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous load if it fails up front.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-24  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [GTK] Many DOM XHTML tests time out
+        https://bugs.webkit.org/show_bug.cgi?id=52553
+
+        * platform/gtk/Skipped: Unskip tests which are no longer timing out.
+
 2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -31 +31 @@
 # The group of tests below are timing out. As we go through them
 # and get more detailed information, we should attach bugs to them.
-dom/xhtml/level3/core/entitygetinputencoding03.xhtml
-dom/xhtml/level3/core/entitygetinputencoding04.xhtml
-dom/xhtml/level3/core/entitygetxmlencoding02.xhtml
-dom/xhtml/level3/core/entitygetxmlencoding03.xhtml
-dom/xhtml/level3/core/entitygetxmlencoding04.xhtml
-dom/xhtml/level3/core/entitygetxmlversion03.xhtml
-dom/xhtml/level3/core/entitygetxmlversion04.xhtml
-dom/xhtml/level3/core/nodegetbaseuri16.xhtml
-dom/xhtml/level3/core/nodegetbaseuri19.xhtml
-dom/xhtml/level3/core/nodegetbaseuri20.xhtml
-http/tests/xmlhttprequest/XMLHttpRequestException.html
-http/tests/xmlhttprequest/connection-error-sync.html
 fast/xmlhttprequest/null-document-xmlhttprequest-open.html
-http/tests/misc/favicon-as-image.html
-media/unsupported-rtsp.html
-security/autocomplete-cleared-on-back.html
-http/tests/security/frameNavigation/cross-origin-opener.html
 
 # Intermittently timing out on Gtk Debug Bot:

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-24  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [GTK] Many DOM XHTML tests time out
+        https://bugs.webkit.org/show_bug.cgi?id=52553
+
+        Properly handle the situation where a synchronous load fails before the inner
+        event loop has started. In this case, we simply do not run the inner event loop,
+        or else it will block indefinitely (since no GIO or libsoup callbacks will fire).
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
+        load if it fails up front.
+
 2011-01-24  Zhenyao Mo  <zmo@google.com>
 

trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -802 +802 @@
     handle->start(context);
 
+    // If the request has already failed, do not run the main loop, or else we'll block indefinitely.
+    if (handle->d->m_scheduledFailureType != NoFailure)
+        return;
+
     syncLoader.run();
 }