Changeset 76591 in webkit

Timestamp:

Jan 25, 2011 7:15:33 AM (13 years ago)

Author:

mario@webkit.org

Message:

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Antonio Gomes.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53073

Make the two steps in the flaky test to be executed sequentially.

• fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Fix flaky test by chaining its two steps up.
• platform/gtk/Skipped: Unskip test.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html (modified) (4 diffs)
• platform/gtk/Skipped (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-25  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Antonio Gomes.
+
+        fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=53073
+
+        Make the two steps in the flaky test to be executed sequentially.
+
+        * fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
+        Fix flaky test by chaining its two steps up.
+        * platform/gtk/Skipped: Unskip test.
+
 2011-01-25  Dirk Schulze  <krit@webkit.org>
 

trunk/LayoutTests/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html

@@ -32 +32 @@
     var resultMap1 = [
       ["Down", "start"],
-      ["", ""]
+      ["DONE", "DONE"]
     ];
 
@@ -53 +53 @@
 
       setTimeout(step1 , 0);
-      setTimeout(step2 , 50);
     }
 
@@ -61 +60 @@
       // focused element ('start') once the best candidate ('end') is not
       // visible in current viewport.
-      initTest(resultMap1);
+      initTest(resultMap1, step1Completed);
     }
 
@@ -73 +72 @@
 
       // And 'resultMap2' re-tries to move focus down.
-      initTest(resultMap2, testCompleted);
+      initTest(resultMap2, step2Completed);
     }
 
-    function testCompleted()
+    function step1Completed()
+    {
+      setTimeout(step2 , 0);
+    }
+
+    function step2Completed()
     {
       if (window.layoutTestController)

trunk/LayoutTests/platform/gtk/Skipped

@@ -5271 +5271 @@
 editing/pasteboard/5761530-1.html
 
-# flaky test (see https://bugs.webkit.org/show_bug.cgi?id=53073)
-fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
-
 # Speech input is not yet enabled.
 fast/speech