Changeset 76633 in webkit


Ignore:
Timestamp:
Jan 25, 2011 1:08:26 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
Location:
trunk
Files:
8 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r76632 r76633  
     12011-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r76625.
     4        http://trac.webkit.org/changeset/76625
     5        https://bugs.webkit.org/show_bug.cgi?id=53119
     6
     7        "incorrect pixel test results" (Requested by rniwa on
     8        #webkit).
     9
     10        * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
     11        * editing/selection/caret-painting-after-paste-undo.html: Removed.
     12        * platform/mac/editing/deleting/5408255-expected.checksum:
     13        * platform/mac/editing/deleting/5408255-expected.png:
     14        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
     15        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
     16        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
     17        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
     18        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
     19        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
     20
    1212011-01-25  Tony Chang  <tony@chromium.org>
    222

  • trunk/LayoutTests/platform/mac/editing/deleting/5408255-expected.checksum

    r76625 r76633  
    1 3d62e6dd2bd0bae57beed5f1d3101ca0
     1ca490445057281bd26f5cab7862bb9cb

  • trunk/Source/WebCore/ChangeLog

    r76626 r76633  
     12011-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r76625.
     4        http://trac.webkit.org/changeset/76625
     5        https://bugs.webkit.org/show_bug.cgi?id=53119
     6
     7        "incorrect pixel test results" (Requested by rniwa on
     8        #webkit).
     9
     10        * rendering/RenderBox.cpp:
     11        (WebCore::RenderBox::localCaretRect):
     12
    1132011-01-25  Patrick Gansterer  <paroga@webkit.org>
    214

  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r76625 r76633  
    29552955    // FIXME: Paint the carets inside empty blocks differently than the carets before/after elements.
    29562956
     2957    // FIXME: What about border and padding?
    29572958    IntRect rect(x(), y(), caretWidth, height());
    29582959    bool ltr = box ? box->isLeftToRightDirection() : style()->isLeftToRightDirection();
    … …  
    29602961    if ((!caretOffset) ^ ltr)
    29612962        rect.move(IntSize(width() - caretWidth, 0));
    2962 
    2963     if (isTable()) {
    2964         if ((!caretOffset) ^ ltr)
    2965             rect.move(IntSize(width() - caretWidth, 0));
    2966     } else if ((!caretOffset) ^ ltr)
    2967         rect.move(IntSize(width() - caretWidth - borderRight() - paddingRight(), borderTop() + paddingTop()));
    2968     else
    2969         rect.move(IntSize(borderLeft() + paddingLeft(), borderTop() + paddingTop()));
    29702963
    29712964    if (box) {
Note: See TracChangeset for help on using the changeset viewer.